Repository navigation
Rate regulator: declare rateReceiverKeepMaxOverTotal, keep-count lines past a service total (E90) - #157
Merged
Conversation
…ines past a service total Declares rateReceiverKeepMaxOverTotal (default 500). The keep counts, the total file and the rate page say keep-count lines count toward the total and a service passes at most that many more per window once it is spent; the rate page states the shipped bound past the total, 550 lines (50 sample, 500 keep-count). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Declares
rateReceiverKeepMaxOverTotal(number, default 500) in the rate module, besiderateReceiverBaselineMaxOverTotal. Ships with log-10x/config#116, which reads the option and setskeepMaxOverTotal: 500in the rate config; a config key without its declaration fails launch, so the two merge together (this one first).Engineering ask E90, option B as ruled: a keep-count line (one of the first K held lines of an ERROR, CRITICAL or FATAL pattern in a window) counts toward the service total like any line, and once the total is spent the service passes at most this many more per window; the rest take the service's action.
0removes the bound.Text changes:
rateReceiverKeepCountsandrateReceiverTotalLookupFiledocs: the "an error storm can exceed the total by the count times the storming patterns" and "no limit per service" clauses are replaced by the bound.doc.md), total section, new sentence: "The error-class lines inkeepCountscount toward the total the same way, and once it is spent the service passes at mostkeepMaxOverTotalmore of them in the window (default 500, counted in lines), so with the shipped settings a burst of new error patterns exceeds the total by at most 550 lines." The config example gainskeepMaxOverTotal: 500.Gate: the regulator harness in log-10x/config
tests/regulatoronghcr.io/log-10x/edge-10x:1.1.150with this checkout mounted; results are in the config PR.🤖 Generated with Claude Code