fix(windows): isolate status output and correct disk I/O - #1488
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (14)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughWindows disk I/O now uses one cumulative logical-disk sample. The parser filters logical drives, converts byte counters to 512-byte sectors, normalizes drive names, and rejects invalid values. Dart disk aggregation now receives the active system and applies Linux-only device filtering. Windows status execution suppresses stderr. Tests, script versioning, display fallback, and cross-platform documentation were updated. Suggested reviewers: Priority: ➖ Normal Change: Bug fix · Severity of issue fixed: Medium Merge Risk: ⚪ Minimal · up to The Windows disk I/O and status-output changes are ready to merge; no current behavior issue requiring correction was identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Summary
--Testing
cargo test -p sbm_parsercargo test -p sbm_nativecargo clippy -p sbm_parser -p sbm_native --all-targets -- -D warningsflutter test --no-pub test/disk_test.dart test/windows_test.dart test/script_version_test.dartflutter analyze --no-pub lib testCloses #1478
Summary by CodeRabbit
Bug Fixes
--when read or write data is unavailable.Compatibility