Skip to content

fix(ui): reopen management modals in list view - #13

Closed
lviobio wants to merge 2 commits into
lonetis:mainfrom
lviobio:dev/environments-reset-on-open
Closed

lviobio wants to merge 2 commits into
lonetis:mainfrom
lviobio:dev/environments-reset-on-open

Conversation

@lviobio

@lviobio lviobio commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

Closing a management modal while editing or creating an item preserved the editor state, so opening it again resumed the previous form instead of showing the list. Reset the editor modes whenever Environments or the shared ListEditorModal opens; this covers Capabilities, Instructions, and Init Scripts, including built-in read-only views. Reset the creation mode when Users opens as well. Resetting on open preserves the closing animation.

Add regression coverage for Close, Escape, and clicking outside each modal. Resource dialogs exercise edit, create, and built-in view modes with unsaved drafts; Users exercises an unsaved creation form. Verify fresh forms keep their expected defaults, including the Init Scripts shebang.

Validation:

  • Reproduced the reopening failure before the respective fixes in all five dialogs.
  • 100 UI tests passed against the local dev server: the Environments and network editor suites; Capabilities, Instructions, and Init Scripts modal and CRUD suites; shared modal reopening tests; and three Users reopening tests.
  • Orchestrator typecheck passed with vue-tsc 3.0.8 and TypeScript 5.9.3.

@lviobio lviobio changed the title fix(ui): reset environment editor when opening modal fix(ui): reopen management modals in list view Oct 10, 2026
@lonetis

lonetis commented Oct 25, 2026

Copy link
Copy Markdown
Owner

This is intended. Otherwise, clicking outside the modal after filling out a form to add a new capability would close it and reset the form, clearing all its content. This feels wrong. Users may also need to look something up elsewhere in agentor. They can safely close the modal and return without losing their progress. Also, you can reset the modals by reloading the page.

@lonetis lonetis closed this Oct 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants