Repository navigation
Conversation
Owner
|
This is intended. Otherwise, clicking outside the modal after filling out a form to add a new capability would close it and reset the form, clearing all its content. This feels wrong. Users may also need to look something up elsewhere in agentor. They can safely close the modal and return without losing their progress. Also, you can reset the modals by reloading the page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing a management modal while editing or creating an item preserved the editor state, so opening it again resumed the previous form instead of showing the list. Reset the editor modes whenever Environments or the shared ListEditorModal opens; this covers Capabilities, Instructions, and Init Scripts, including built-in read-only views. Reset the creation mode when Users opens as well. Resetting on open preserves the closing animation.
Add regression coverage for Close, Escape, and clicking outside each modal. Resource dialogs exercise edit, create, and built-in view modes with unsaved drafts; Users exercises an unsaved creation form. Verify fresh forms keep their expected defaults, including the Init Scripts shebang.
Validation: