Skip to content

Add clang-tidy details to current check - #3003

Open
jwrober wants to merge 2 commits into
longturn:masterfrom
jwrober:build/clang-tidy-ci-2
Open

jwrober wants to merge 2 commits into
longturn:masterfrom
jwrober:build/clang-tidy-ci-2

Conversation

@jwrober

@jwrober jwrober commented Sep 13, 2026 •

Copy link
Copy Markdown
Collaborator

In order for us to have a clang-tidy pre-check like we do for clang-format we need to fully know what the CI is going to see. Adding code to the existing CI to run against the whole tree. It will always fail, but for me that is ok. We use it for diagnostics.

Part of #2464
part of #3000

@jwrober
jwrober requested a review from lmoureaux September 13, 2026 18:08

@lmoureaux lmoureaux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A failure in utility will prevent the workflow from continuing. Since we have continue-on-error, what about a structure like this:

  1. utility - if this fails, the job fails
  2. common - if this fails, the job fails
  3. ai client server tools - still allowed to fail for now

Then we move folders from 3 to 1 over time.

Comment thread .github/workflows/build.yaml Outdated
@jwrober

jwrober commented Sep 13, 2026

Copy link
Copy Markdown
Collaborator Author

A failure in utility will prevent the workflow from continuing. Since we have continue-on-error, what about a structure like this:

  1. utility - if this fails, the job fails
  2. common - if this fails, the job fails
  3. ai client server tools - still allowed to fail for now

Then we move folders from 3 to 1 over time.

This is effectively what I was thinking too. I have a branch in my local I started testing with yesterday when I realized the repo isn't quite ready. The test for utility and common I think can be combined. I kept utility separate because of the spec*.h files that don't pass any kind of IWYU check due to their nature.

image

@jwrober

jwrober commented Sep 13, 2026

Copy link
Copy Markdown
Collaborator Author

I'll need to bring in #3001 and #3002 in here in a rebase for this to work as expected.

@lmoureaux

Copy link
Copy Markdown
Contributor

Both merged

@jwrober
jwrober force-pushed the build/clang-tidy-ci-2 branch from 48d878c to e55627c Compare September 14, 2026 01:37
@jwrober
jwrober requested a review from lmoureaux September 14, 2026 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants