fix: enforce read-only execution in SQL example - #18
Merged
Conversation
fitz2882
marked this pull request as ready for review
September 5, 2026 13:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SQL example previously relied on statement-prefix filtering, which did not enforce read-only execution. Install an SQLite authorizer that permits reads and denies state-changing operations, with query_only enabled after fixture setup. Valid SELECT, CTE, recursive, and window queries retain their behavior.
Validation: 133 focused tests pass, including nine new SQLite tests; four regressions fail against the previous source. Tests use disposable in-memory fixtures with no model or telemetry calls. Fresh independent review approved the final commit and all 11 CI jobs passed. Runtime resource exhaustion is outside this fixture-mutation fix.