Repository navigation
Conversation
…matches in the NoKV helper Signed-off-by: wchwawa <wch19961116@gmail.com>
… SDK wire schema Signed-off-by: wchwawa <wch19961116@gmail.com>
This was referenced Sep 26, 2026
4 tasks done
…cation path Signed-off-by: song <liusongstep@gmail.com>
songoow
changed the title
The live qualification opens three helpers but reported only the first non-null schema any of them declared, so helpers that disagreed (for example null/v9/v10 or v9/v10/v9) produced a report naming one schema for the whole run. Record every opened helper's declaration in open order as nokv_protocol_schema_observations and name nokv_protocol_schema only when all of them agree; it is null otherwise. The derivation moves into exerciseQualificationSequence so the deterministic harness covers it. The schema stays observed metadata: disagreement does not fail the probe, and no admission, CAS or pass criterion changes. The ladder row carries the observations as evidence, and the docs no longer say that only 0.11.0 declares no schema: the 0.11.1 release wheel exports none either. Signed-off-by: wchwawa <wch19961116@gmail.com>
wchwawa
marked this pull request as ready for review
October 14, 2026 02:14
Collaborator
Author
|
Thanks @songoow for bringing this up to date and keeping it on the current Stage 2A path. I added a small follow-up in f5bdb51 to preserve all three helpers' schema declarations instead of silently keeping the first non-null value. Independent regression and real NoKV E2E checks now close the P2. Mixed declarations remain observational, and the existing admission and failure gates are unchanged. @huangruiteng, I've marked this ready for your review and updated the PR's validation and error-code notes. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NoKV qualification reports now preserve each helper's declared SDK wire schema and typed helper-open refusal codes. All three declarations are recorded in opening order, including unknown values; the summary names a schema only when all three agree. For example,
[null, v9, v10]now reportsnullinstead of incorrectly namingv9. These declarations are observations, not protocol negotiation or an additional admission gate. Free-form helper errors remain excluded from CLI stderr.This uses the current Stage 2A path. Seed routing, the SDK 0.11.1/API 1 pin and incarnation-fenced publication already belong to main. Existing admission, CAS, qualification and failure criteria remain intact; retired Stage 0/shadow paths stay removed.
Error-reporting change relative to main: the real 0.11.0 wheel now reports
invalid_configinstead ofnokv_transport_protocol_failed. It still exits 1 and fails the ladder row. Version mismatch and invalid configuration continue to shareinvalid_config; unsupported SDK capabilities reportnokv_sdk_capability_mismatch. The P2 follow-up does not change these codes.Independent validation at
f5bdb51f5, compared with parent57f7fae42:Schema variants changed only SDK declarations while retaining real storage operations; they do not prove server support for the declared versions. This remains bounded single-owner evidence, not experimental seeds-server interoperability, HA, capacity or production promotion qualification. Original contributor commits remain in the branch.