Skip to content

fix(release): restore all adopted browser fixtures before attestation - #6510

Merged
loopx-agent merged 1 commit into
mainfrom
codex/release-141-restore-fixtures
Oct 15, 2026
Merged

loopx-agent merged 1 commit into
mainfrom
codex/release-141-restore-fixtures

Conversation

@loopx-agent

Copy link
Copy Markdown
Collaborator

The fixture-only recovery extractor now admits the reviewed navigation scenario, but cleanup still lists only the previous three files. Restore the complete tracked browser-fixture directory so the extractor remains the sole membership owner and every adopted test correction is removed before attestation.

Validation executes the actual extraction and restoration commands on isolated synthetic Git repositories: the previous workflow leaves the corrected scenario dirty, the new workflow restores it; immutable product and prebuilt package bytes remain unchanged. Empty input and invalid/unmerged/unrelated/symlink checks preserve their behavior. Existing release-artifacts smoke and diff checks pass. Risk/quality/exact-head review follow before merge.

This completes #6509 cleanup; no product tag, package build, extraction authority, deployment policy, UI or runtime behavior changes. The root fix removes the duplicated list rather than growing a second owner.

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

@loopx-agent loopx-agent left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer: model_agent; model=gpt-6.1-sol; provider=OpenAI; runtime_reported; reasoning_effort=xhigh

Approval conclusion (author-owned PR; GitHub blocks formal self-approval). Exact head 9d57db71e5915b6c38f6e2562d31867142e22225.

动机

维护不可变正式版本的发布者。提取范围已经支持修正后的导航场景,但收尾仍重复旧的三个路径,导致该场景在来源证明前没有恢复。收尾恢复整个已跟踪测试目录,所有提取的修正都返回原产品标签内容。本 PR 只完成恢复工具的收尾一致性,实际 PyPI 发布和安装读回仍待恢复工作流完成。这是合并后检查完整生命周期发现的遗漏,之前只执行提取检查不足以证明收尾。已在 #6509 公开纠正原评审记录,恢复发布尚未启动。

改动思路

提取的精确允许集合继续是唯一成员定义,收尾按既有测试目录恢复,删除第二份易漏更新的列表。仅改一条 git restore 路径,不改提取授权、产品或包字节、来源记录及部署权限。最强反对意见是目录恢复会覆盖无关内容,因此检查了路径归属:它只在隔离 runner 中恢复已跟踪测试文件;不会清理未跟踪数据,也不会触碰产品目录或构建包。比增加第四个路径更直接,并使后续允许的同目录测试不再要求同步第二份列表。

具体改动

验收依据为 docs/product/release-readiness.md 在 186e70e138a5ddba2878af747ce2adb645eaf8c5 的 restore-browser-fixtures 条款,要求测试通过后恢复夹具并再次核对预先构建的包。当前改动实现这个既有条件,没有改写文档来迁就结果。

关键代码讲解

git restore 的三个单文件 pathspec 替换成 examples/personal-workspace-browser 目录。Git 仍从原产品 checkout 的索引恢复已跟踪内容,不增加删除未跟踪文件、移动标签或提取其他产品文件的权限。下游 verify-checksums 保持原样,继续校验既有 wheel、sdist 和 SHA256SUMS,然后在 RELEASE-SOURCES 中绑定这些摘要。提取端四路径允许集合、完整提交与主线祖先检查、常规文件类型检查均与当前基线相同;这次只消除其收尾消费者的重复知识。

对主干的风险

没有阻断性发现。实际运行了 base/head 的工作流提取 Python 以及 Git restore 命令:同一已合入常规修正会在基线留下改变的 goal-workspace-m2,在 head 返回原字节;产品文件和已构建包的字节前后完全相同。空输入、缩写提交、无关提交、未合入提交和软链接拒绝仍保留,合成仓库避免接触任何活跃 Goal 或用户工作树。现有 release-artifacts smoke、风险 canary 和 diff 检查通过,精确质量凭据有效;托管策略不查询 PR CI。远端发行工作流、PyPI 上传和安装读回仍待实际完成,不用合成包字节证明真实发行物内容。前端、Lark 和 CLI 产品入口都未改变。

我的整体评价

APPROVE。long_horizon 因删除重复成员列表而改善,user_experience 保持相同发布操作,无额外设置或授权。提取的精确允许集合继续是唯一成员定义,收尾按既有测试目录恢复,删除第二份易漏更新的列表。仅改一条 git restore 路径,不改提取授权、产品或包字节、来源记录及部署权限。这就是本批已实施的相关简化;没有增加新状态、共享词表、抽象或兼容分支。原提取评审证据仅用于仍未改变的输入与权限路径,并已用当前完整生命周期重新验证,未继承旧结论。精确 head 仍须通过 readiness 和维护者授权才能合并,实际 PyPI 成功继续单独验证。

English verdict: APPROVE at 9d57db71e5915b6c38f6e2562d31867142e22225. Restoring the existing tracked fixture directory removes duplicated cleanup membership. Executed base/head full extraction/restoration proves the prior missed fixture and complete head cleanup while preserving product/artifact bytes and rejection/default paths. Artifact/risk/diff checks pass. Remote recovery publication and PyPI readback remain pending.

@loopx-agent
loopx-agent merged commit 1fbc918 into main Oct 15, 2026
5 of 6 checks passed
@loopx-agent
loopx-agent deleted the codex/release-141-restore-fixtures branch October 15, 2026 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant