Repository navigation
Conversation
Signed-off-by: aihop <4408344+hhyykk@users.noreply.github.com>
Signed-off-by: aihop <4408344+hhyykk@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal And Delivered Outcome
An enabled Goal-wide contract can still contain unmet criteria after all local Todos finish with
no_followup. Previouslyquota should-runderivedterminal_no_followup, stopping automation despite that contract. Retain the existing acceptance owner's verification gap and route it through replan until current full-contract verification passes.main, source baseline369eda5f71a41062636c825b4d9b60f1ecbaf28c.terminal_no_followup,should_run=falseautonomous_replan_required,should_run=trueterminal_no_followup,should_run=falseautonomous_replan_required,should_run=trueBoth arms retained all criterion IDs. The defect was ignoring them at termination, not losing persisted criteria. This comparison used the same actual provider states and separate serving runtimes per code version; it is not a latency measurement or full-output parity claim for the changed branch.
Author Declaration
docs/architecture/rfcs/shared-goal-alignment-and-governed-amendment-v0.md§3.7 anddocs/architecture/rfcs/typescript-control-plane-migration-v0.md§§2.1, 2.3, at the source baseline above.acceptance_contract.tsowns the gap;replan_semantics.tsrejects prose-only discharge; Python adapts existing frontier/terminal consumersSelf-check: author review with clean-code-guard, test-guard and docs-guard; source/CLI verification, negative cases and checks below. This is not independent review approval.
Scope And Continuation
The gate applies to enabled Goal-wide contracts, including legacy omitted scope, once active advancement work is exhausted. Local completion or a vision ACK cannot replace canonical verification. Current full verification clears the gap; contract/work changes invalidate old success. Fingerprints bind Goal/instance, contract/work and verification facts; repeating identical results under another operation ID is not new progress.
Explicit
selected_work, disabled/absent governance and runnable advancement retain their existing boundary. Historical receipts remain unchanged. No new ledger, persisted schema, RPC, configuration, provider routing, permission or automatic verifier/repair dispatch. Existing Todo-bound Hosts still block empty selections even when the envelope requires replan. Freshness uses existing contract/work bindings; this adds no artifact freshness oracle.This is independently testable and reversible at the existing acceptance/frontier boundary. The broader long-horizon Goal remains open under the RFC owners above: configured criteria do not prove complete natural-language intent or model adherence. Related future-facing pass: reuse the native owner across consumers; no additional abstraction justified. Current open proposals were checked: #6473 owns optional checker/oracle/UI work, and #6396 retires Markdown writers; neither supplies this termination gate.
Validation
real_entrypoint,real_backendregression_parityshould_runassertion.unitregression_paritystaticintegrationintegrationReproduce the durable regression with
python -m pytest -q tests/control_plane/test_goal_acceptance_closeout.py tests/control_plane/test_goal_terminal_no_followup.pyin the configured source-checkout test environment, using supported Node.js 22.22.3+. Native regression:node --no-warnings --experimental-strip-types --test tests/control_plane_ts/goal_acceptance_closeout.test.ts.Frontend / Visual Evidence
UI impact: none. No changed visual surface; screenshots not applicable.
Type of Change / LoopX Area
Bug fix, documentation and regression tests. Control plane: Goal acceptance, frontier, quota/Turn consumers. Direction: shared Goal alignment R4 / long-horizon S11, bounded partial delivery.
Shared-authority RFC fixture impact
Existing canonical Todo and acceptance schemas are unchanged. Changed dimensions: unmet Goal-wide criteria after local closure, evidence freshness/identity, replan transport and terminal refusal. File/SQLite conformance arms ran. No provider routing, promotion or compatibility-projection cutover; no legacy/File/PostgreSQL three-arm qualification claim.
Boundary Checklist