Skip to content

test(dashboard): follow the renamed delivery recheck control in team smokes - #6553

Closed
songoow wants to merge 1 commit into
loopx-project:mainfrom
songoow:codex/team-evidence-smoke-label-20261016
Closed

songoow wants to merge 1 commit into
loopx-project:mainfrom
songoow:codex/team-evidence-smoke-label-20261016

Conversation

@songoow

@songoow songoow commented Oct 15, 2026

Copy link
Copy Markdown
Collaborator

Summary

The build lane has failed on every pull request since 2026-10-15 at team-evidence-return-smoke.mjs:67, waiting for a button named "重新读取证据" that no longer exists. PR #6473 (4ae2dcd3a) renamed the evidence region's control to "重新检查交付" / "Check delivery again" because it now runs the configured delivery checks, but the four packaged team smokes kept the old locator; #6473 itself merged with that lane red, so the mismatch reached main.

This aligns the six locators in the four smokes with the shipped label. Tests only, no product change.

  • apps/presentation/dashboard/smoke/team-evidence-return-smoke.mjs (3 sites)
  • apps/presentation/dashboard/smoke/team-feedback-recovery-smoke.mjs
  • apps/presentation/dashboard/smoke/team-result-use-recovery-smoke.mjs
  • apps/presentation/dashboard/smoke/team-task-revalidation-smoke.mjs

Validation

All four smokes run locally in packaged mode (LOOPX_PERSONAL_WORKSPACE_PACKAGED=1, bundle built with scripts/chat_bundle.py build --install from a tree whose evidence component and smokes are identical to main):

  • team-evidence-return: passed (checked outputs, navigation, downstream loss/revocation/restoration, core loss, keyboard return, fresh evidence/list, pagination, mobile)
  • team-feedback-recovery: passed
  • team-result-use-recovery: passed
  • team-task-revalidation: passed

Before the change team-evidence-return reproduced the CI timeout locally at the same line.

Follow-up for the owner

Three product strings still tell the reader to "重新读取证据" while the control now reads "重新检查交付" (goal-team-evidence.tsx error copy, goal-team-adoption.tsx unavailable copy, goal-team-lineage.tsx guidance). That is owner-language copy on a product surface and is left for the owner rather than bundled into a tests-only fix.

Merging this restores the build lane for the open PRs once they rebase; it does not touch loopx/**, scoring, permissions or runtime behavior.

🤖 Generated with Claude Code

…smokes

PR loopx-project#6473 renamed the evidence region's control from "重新读取证据" to
"重新检查交付" (it now runs the configured delivery checks), but the four
packaged team smokes still looked for the old label. The build lane has
failed at team-evidence-return-smoke.mjs:67 on every PR since, waiting for
a button that no longer exists; loopx-project#6473 itself merged with that lane red.

Align the six locators with the shipped label. No product change.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Signed-off-by: song <liusongstep@gmail.com>
@mergify

mergify Bot commented Oct 15, 2026

Copy link
Copy Markdown

This pull request has merge conflicts with main and cannot be merged
until they are resolved. Please rebase or merge the base branch, @songoow.

Choose the remote for the base repository, not an out-of-date fork.
For a fork clone, first inspect git remote -v; upstream must point
to https://github.com/loopx-project/loopx.git. If it is absent, add it
with git remote add upstream https://github.com/loopx-project/loopx.git.
Then run:

git fetch upstream
git rebase upstream/main
# Resolve each conflict, git add the resolved files, then git rebase --continue.
git push --force-with-lease origin HEAD

For a same-repository clone whose origin points to
https://github.com/loopx-project/loopx.git, use origin instead of
upstream for fetch/rebase. If you prefer merging the base, use
git merge <base-remote>/main and push normally.

Keep the DCO Signed-off-by trailer on every commit when you rebase.
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify Bot added the needs-rebase Mergify: the pull request has merge conflicts with its base branch label Oct 15, 2026
@songoow

songoow commented Oct 15, 2026

Copy link
Copy Markdown
Collaborator Author

Superseded: ec327628f (test(workspace): follow the current delivery check action) landed on main with the same locator alignment, so this PR now conflicts and is no longer needed. Closing; the open PRs get the green build lane by rebasing onto current main.

@songoow songoow closed this Oct 15, 2026
@songoow
songoow deleted the codex/team-evidence-smoke-label-20261016 branch October 15, 2026 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-rebase Mergify: the pull request has merge conflicts with its base branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant