Skip to content

fix(dashboard): keep completed task history read-only #6656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
huangruiteng merged 1 commit into from
Oct 16, 2026
Merged

fix(dashboard): keep completed task history read-only #6656

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions apps/presentation/dashboard/smoke/todo-ownership-smoke.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,25 @@ try {
}
const notesLabel = locale === "en" ? "Notes" : "备注";
const evidenceLabel = locale === "en" ? "Evidence" : "证据";
// Canonical deferred records may retain done=true; legacy completed records
// may omit status. The real adapter and inspector must distinguish them.
for (const [fields, completed, resumable] of [
[{done: true}, true, false],
[{done: true, status: "done"}, true, false],
[{done: true, status: "deferred"}, false, true],
[{done: false, status: "blocked"}, false, true],
]) {
const source = todoItemSchema.parse({todo_id: "retained-task", text: "Read retained work", ...fields});
const todo = workspaceAgentTodoFromItem(source, "fallback-id");
const drawer = render(ContextDrawer, {agents: [], callbacks: {}, onClose() {}, selection: {
kind: "todo", item: {...todo, goalId: "test-goal", goalTitle: "Test Goal"},
}});
assert.equal(drawer.includes("personal-task-completed-note"), completed, "Completed history remains read-only");
assert.equal(drawer.includes("personal-task-inspector-actions"), !completed, "Completed records never expose new mutations");
assert.equal(drawer.includes(locale === "en" ? "Resume task" : "恢复任务"), resumable,
"Only explicitly paused work offers resume");
assert.equal(source.done, fields.done, "Presentation never rewrites the recorded lifecycle");
}
for (const invalid of [null, "dependency_cycle"]) {
const source = todoItemSchema.parse({todo_id: "todo_cycle", text: "Review dependent work", done: false,
status: "open", resume_when: "todo_done:todo_peer", resume_ready: false,
Expand Down
12 changes: 6 additions & 6 deletions apps/presentation/dashboard/src/features/personal-workspace/context-drawer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -645,8 +645,8 @@ export function ContextDrawer({ agents, attentionHistory = [], onSelectAttention
<>
<section className="personal-task-inspector-summary">
<div className="personal-task-inspector-status">
<span className={selection.item.status === "done" ? "is-done" : selection.item.status === "blocked" ? "is-blocked" : "is-open"}>
<i />{selection.item.status === "done" ? t("drawer.taskStatusCompleted") : selection.item.retryReadback ? t("drawer.resumePending") : selection.item.status === "deferred" ? t("drawer.taskStatusDeferred") : selection.item.status === "blocked" ? t("drawer.taskStatusBlocked") : t("drawer.taskStatusOpen")}
<span className={todoCompleted ? "is-done" : selection.item.status === "blocked" ? "is-blocked" : "is-open"}>
<i />{todoCompleted ? t("drawer.taskStatusCompleted") : selection.item.retryReadback ? t("drawer.resumePending") : selection.item.status === "deferred" ? t("drawer.taskStatusDeferred") : selection.item.status === "blocked" ? t("drawer.taskStatusBlocked") : t("drawer.taskStatusOpen")}
</span>
{selection.item.priority ? <span>{selection.item.priority}</span> : null}
<span>{selection.item.taskClass === "advancement_task" ? t("drawer.taskAdvancement") : selection.item.taskClass ?? t("drawer.taskOrdinary")}</span>
Expand All @@ -662,7 +662,7 @@ export function ContextDrawer({ agents, attentionHistory = [], onSelectAttention
<dl>
<div><dt>Goal</dt><dd>{selection.item.goalTitle}</dd></div>
<div><dt>{t("common.owner")}</dt><dd>{selection.item.claimedBy ? selection.item.ownerLabel ?? selection.item.claimedBy : t("drawer.notAssigned")}</dd></div>
<div><dt>{t("common.status")}</dt><dd>{selection.item.status === "done" ? t("drawer.taskStatusCompleted") : selection.item.retryReadback ? t("drawer.resumePending") : selection.item.status === "deferred" ? t("drawer.taskStatusDeferred") : selection.item.status === "blocked" ? t("drawer.taskStatusBlocked") : t("drawer.taskStatusOpen")}</dd></div>
<div><dt>{t("common.status")}</dt><dd>{todoCompleted ? t("drawer.taskStatusCompleted") : selection.item.retryReadback ? t("drawer.resumePending") : selection.item.status === "deferred" ? t("drawer.taskStatusDeferred") : selection.item.status === "blocked" ? t("drawer.taskStatusBlocked") : t("drawer.taskStatusOpen")}</dd></div>
<div><dt>{t("drawer.priority")}</dt><dd>{selection.item.priority ?? t("drawer.notSet")}</dd></div>
{selection.item.completedAt ? <div><dt>{t("drawer.completedAt")}</dt><dd><time dateTime={selection.item.completedAt}>{selection.item.completedAt}</time></dd></div> : null}
{selection.item.dependencies ? <div><dt>{t("drawer.dependencies")}</dt><dd>{selection.item.dependencies.join(" · ") || t("common.none")}</dd></div> : null}
Expand All @@ -679,10 +679,10 @@ export function ContextDrawer({ agents, attentionHistory = [], onSelectAttention
<div><dt>{t("drawer.validationDigest")}</dt><dd><code>{selection.item.validationDigest}</code></dd></div>
{selection.item.validationRevisionActor ? <div><dt>{t("drawer.validationRevisionActor")}</dt><dd>{selection.item.validationRevisionActor}</dd></div> : null}
</> : null}
<div><dt>{t("drawer.nextTransition")}</dt><dd>{selection.item.nextTransition ?? (selection.item.status === "done" ? t("drawer.taskNextCompleted") : selection.item.resumeInvalidReason === "dependency_cycle" ? t("drawer.taskNextCycle") : selection.item.retryReadback ? t("drawer.taskNextDeferred") : selection.item.resumeReady ? t("drawer.taskNextResumeReady") : selection.item.status === "deferred" ? t("drawer.taskNextDeferred") : selection.item.status === "blocked" ? t("drawer.taskNextBlocked") : t("drawer.taskNextOpen"))}</dd></div>
<div><dt>{t("drawer.nextTransition")}</dt><dd>{selection.item.nextTransition ?? (todoCompleted ? t("drawer.taskNextCompleted") : selection.item.resumeInvalidReason === "dependency_cycle" ? t("drawer.taskNextCycle") : selection.item.retryReadback ? t("drawer.taskNextDeferred") : selection.item.resumeReady ? t("drawer.taskNextResumeReady") : selection.item.status === "deferred" ? t("drawer.taskNextDeferred") : selection.item.status === "blocked" ? t("drawer.taskNextBlocked") : t("drawer.taskNextOpen"))}</dd></div>
</dl>
</section>
{!readOnly && selection.item.status !== "done" ? <div className="personal-task-inspector-actions" aria-label={t("drawer.taskActions")}>
{!readOnly && !todoCompleted ? <div className="personal-task-inspector-actions" aria-label={t("drawer.taskActions")}>
<details className="personal-task-management">
<summary><MoreHorizontal size={16} />{t("drawer.taskManage")}</summary>
<div>
Expand Down Expand Up @@ -750,7 +750,7 @@ export function ContextDrawer({ agents, attentionHistory = [], onSelectAttention
<summary>{t("drawer.notes")}</summary>
<MarkdownText text={selection.item.note} />
</details> : null}
{selection.item.status === "done" ? <div className="personal-task-completed-note"><Check size={16} /><span><strong>{t("drawer.taskCompletedTitle")}</strong><small>{t("drawer.taskCompletedNote")}</small></span></div> : null}
{todoCompleted ? <div className="personal-task-completed-note"><Check size={16} /><span><strong>{t("drawer.taskCompletedTitle")}</strong><small>{t("drawer.taskCompletedNote")}</small></span></div> : null}
</>
) : null}

Expand Down
Loading