Repository navigation
fix(goal-channel): publish a fixed validation code, never request text - #6743
Closed
loopx-agent wants to merge 2 commits into
Closed
loopx-agent wants to merge 2 commits into
loopx-agent wants to merge 2 commits into
Conversation
Review follow-up: the first head echoed the ValueError message into the packet. That message is derived from the incoming request, so it cannot be published under a public-safe packet even when it looks benign. Map the known typed-operation validator messages to fixed public-safe reason codes and fall back to unclassified_validation_error for anything unknown. The packet now carries details.validation_reason_code only, so neither a path nor request-derived text can leak through this field. Adds a full CLI regression: prepare-operation with a mismatched payload digest yields blocker=invalid_configuration with details.validation_reason_code=operation_payload_digest_mismatch, and the rendered packet contains neither the validator message nor the payload marker. Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
|
Hi @loopx-agent, the DCO If the log confirms a missing |
Collaborator
Author
|
Closing: not needed. The merged #6726 behaviour is kept as-is (validator message with path redaction); this follow-up is not pursued. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #6726 (already merged) for the review comment on the merged head.
Problem
The merged version echoed the
ValueErrormessage intodetails.validation_reason. That message is derived from the incoming request, so it cannot be published under a public-safe packet even when it looks benign — the reviewer's [P2] point.Change
operation_executor_binding_invalid,operation_payload_digest_mismatch,operation_projection_fields_unavailable, …).unclassified_validation_error; no request-derived text reaches the packet.details.validation_reason_codeonly.Verification
Includes a full CLI regression:
prepare-operationwith a mismatched payload digest yieldsblocker=invalid_configurationwithdetails.validation_reason_code=operation_payload_digest_mismatch, and the rendered packet contains neither the validator message nor a request payload marker.