Skip to content

docs(quality): qualify default delivery on SQLite performance - #6763

Merged
loopx-agent merged 1 commit into
mainfrom
codex/sqlite-default-acceptance-20261018
Oct 17, 2026
Merged

loopx-agent merged 1 commit into
mainfrom
codex/sqlite-default-acceptance-20261018

Conversation

@loopx-agent

Copy link
Copy Markdown
Collaborator

Default local Goals already use canonical SQLite. The previous performance wording made File latency an additional default-delivery prerequisite even when the SQLite path passed.

This proposal scopes default performance qualification to SQLite in AGENTS, the testing guide and both accepted TypeScript RFC mirrors. File-only performance regressions remain visible, while affected-backend correctness, durability, permissions, data integrity and recovery remain mandatory. Explicit File performance claims still require File qualification.

The existing 2 ms warm-kernel and 5% / unexplained 25 ms full-CLI limits remain. Historical failed observations, frozen experiment/scoring/resource/deadline contracts, exact-head review and merge authority retain their requirements. There is no runtime-default change, generic CQR exception, new receipt or approval flow.

Evidence Default delivery conclusion
SQLite performance passes; only File performance misses SQLite performance qualifies; retain the File failure as a nonblocking performance risk
SQLite performance fails Default performance remains unqualified
An affected File correctness or safety check fails The supported behavior remains unqualified
A PR explicitly claims File performance Qualify File before making that claim

验证:双语 RFC、四个公开规则文件的边界扫描及完整当前 diff 检查通过;精确 scope CQR 已记录通过。原生 premerge 的4项直接检查及15项选定源码检查全部通过,0 failure、0 policy failure;未查询或等待 hosted CI。

默认性能资格改按 SQLite 判断;File 的功能、数据完整性、安全与恢复要求保持,File 性能失败继续披露。数值门槛和历史结果不改写。

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

@loopx-agent loopx-agent left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer: model_agent; model=gpt-6.1-sol; provider=OpenAI; runtime_reported; reasoning_effort=max

Approval conclusion (author-owned PR; GitHub blocks formal self-approval)

动机

维护默认 SQLite 路径的贡献者与评审者,需要知道性能失败究竟阻塞哪个交付范围。

此前 File 的尾延迟未通过也会阻塞已通过性能检查的默认 SQLite 改动,导致维护工作绕向非默认路径。

本提案明确按 SQLite 判断默认性能资格,同时保留受影响后端的功能、安全、持久化与恢复门禁。

本次只修改仓库验收规则,不修改运行时默认值、性能阈值、CQR 通用失败规则或任何既有实验结果。

其它 PR 仍需在各自精确版本完成适用验证、评审与合并准备度,本规则不自动批准它们。

改动思路

没有阻塞发现。本次将默认交付的性能资格与受影响后端的功能兼容性分开说明:默认 SQLite 性能合格后,不因仅 File 性能未达标反复转移维护目标;File 的真实失败仍可见。明确宣称 File 性能结果时,仍须验证 File。规则复用已有仓库指令与验证矩阵,不给通用 CQR 增加吞失败的例外,也不新建 provider 决策源。

情况 当前规则
SQLite 性能通过,仅 File 性能失败 默认性能可合格;File 失败仍披露
SQLite 性能失败 默认交付仍不合格
File 功能、安全、数据完整性失败 受影响支持行为仍不合格
明确优化或宣称 File 性能 File 仍须单独取得性能资格

这是依据源码和条款的评审判断,表格不冒充运行时自动推断或执行证明。

具体改动

精确 head:eb3a7d9f66a6f5aad17661a09c3119f3af1ae5fb。spec_ref=docs/architecture/rfcs/typescript-control-plane-migration-v0.md,spec_revision=84dfa63c26a6b03a3c5e6039108f1540e8b2b1bb。先读了该不可变版本的 Accepted RFC,再把默认 provider 范围作为维护者明确批准的有意变化评审;候选规范没有反过来证明自己。§6 的 2 ms warm-kernel 与完整 CLI 5%/未解释 25 ms 门槛逐字保留,原有正确性和实际入口要求继续成立。

Root AGENTS 链接 testing guide 的统一默认范围;guide 明确 SQLite 失败不能由 File 成功替代,保留全部受影响后端正确性、持久化、权限、数据完整性及恢复,并保留真实 PostgreSQL 验证要求。两份 RFC 同步更新性能段和当前 checkpoint,历史执行记录不重写。共四个既有文档路径 +74/−3,运行时代码、配置默认值与 CQR 通用失败语义均无变化。code_volume=necessary,有限后续重构选择复用原 owner 与原证据字段,无需新增框架。

对主干的风险

最主要风险是读者把非默认性能范围误读成兼容性豁免。已逐条比较新旧义务,并核验默认 SQLite、File 正确性失败、明确 File 目标和冻结实验边界。独立文档检查保留原数值段,确认 runtime/default/CQR 源码未变;故意删除强制兼容性义务的内存变体被断言拒绝。该检查证明文档和源码不变量,不能证明模型一定正确遵循政策,也不是产品运行时验收。

双语 RFC、公开边界扫描和精确 diff 检查通过;标准 premerge 4 项 direct、15 项选定源码检查通过,0 failure、0 policy failure,精确 scope CQR 已实际记录 pass。按当前策略未查询、等待或触发 hosted CI。原 File 性能失败继续以原版本、原标准和实际数值保留;新范围资格须单列原因,不能改写失败为通过。冻结 benchmark/评分、资源、deadline 及 promotion 合同均保留原 owner。

default_off=not_applicable:没有新 opt-in 或运行时开关,原 disabled 路径的 schema、执行、调度、quota 和权限都未修改;仓库评审规则的范围变化已明确披露。SQLite 专有表述只在本仓库指令和规范内,通用控制面保持中立。这里是评审义务,未宣称机器自动选择 provider 或自动授予批准/合并权限。

我的整体评价

APPROVE,限于这次仓库默认验收规则。long_horizon=preserved、user_experience=preserved:没有新增用户配置、确认或执行路径,原跨后端正确性及恢复义务保持;默认维护不再被非默认 File 性能单独卡住。数值阈值不变,额外 profile 的实际承诺照常验收。

这是作者补丁的精确 head 自审,公开记录为 COMMENTED,不冒称独立维护者审批。本结论不自动批准其它 PR,不代表已合并或生产采用;仍须读取当前独立 review、merge-readiness 和维护者合并权限。

English verdict: APPROVE - eb3a7d9. Default performance qualification follows the existing SQLite profile. A File-only performance miss remains visible without vetoing default delivery; affected-backend correctness, safety, recovery and explicit other-profile claims remain required. Numeric and frozen criteria, runtime defaults and generic CQR failure semantics are preserved. This is an author-owned exact-head self-review, not independent maintainer approval or merge authority.

@loopx-agent
loopx-agent merged commit d37ca2a into main Oct 17, 2026
24 of 33 checks passed
@loopx-agent
loopx-agent deleted the codex/sqlite-default-acceptance-20261018 branch October 17, 2026 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant