Repository navigation
nix workflow cancels superseded PR runs - #321
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picked from #319, keeping its commit under Jifeng's authorship.
Problem
The
nixworkflow buildsojonmacos-14for every PR push, and each run is a cold ~48-minute build. With noconcurrencyblock, a new push to a PR leaves the older run going to completion. On Sep 18, Sep 28 and Oct 1 superseded PR runs burned ~300–400 macOS minutes a day (billed ~10× Linux).Change
A workflow-level
concurrencygroup keyed on the PR number (or ref) cancels a PR's in-progress run when a newer commit arrives.cancel-in-progressis true only forpull_request: pushes tomainandworkflow_dispatchstill build every commit; overlapping ones queue instead of being cancelled.Larger follow-ups, not in this PR: drop the darwin leg from PR runs (~1,000–1,400 macOS min/day) and add a binary cache so darwin builds stop starting cold.