Add ADR-0024: sandcastle is not a language constraint; correct ADR-0002#105
Merged
Merged
Conversation
Investigated whether extending /afk & /hitl to non-TS target languages (dotnet, rust) needs a different underlying agent-sandbox engine than @ai-hero/sandcastle. Verified against sandbox-runner.ts, reviewer-adapter.ts, and sandcastle's own published README: every sandcastle API call site takes a Docker image name, git worktree path, and CLI-shaped options — nothing about a target project's language. The multi-language gap is not an engine problem; it's that ADR-0002's per-language Dockerfile extension point was named but never built. Also corrected ADR-0002's stale guidance to derive per-language Dockerfiles FROM sibling devcontainer-* images (heavy VS Code bases, never actually built out) via a dated addendum, superseding it with deriving from lean official upstream SDK images instead — matching the existing Dockerfile/Dockerfile.opencode pattern. Docs-only; no code changes. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/afk//hitlto non-TypeScript target languages needs a different agent-sandbox engine than@ai-hero/sandcastle. Verified againstsandbox-runner.ts,reviewer-adapter.ts, and sandcastle's own published README that its API surface (createSandbox,sandbox.run(),Output.object()) is entirely Docker-image/worktree/CLI-shaped — no target-language assumption anywhere.docs/adr/0024-sandcastle-is-not-a-language-constraint.mdrecords this.FROMsiblingdevcontainer-*repos) was separately stale — never executed, and the wrong default (heavy VS Code bases). Corrected via a dated addendum superseding it with lean official upstream SDK images.Verification
devcontainer-*/language-list mentions — only the two files touched here reference the (now-superseded) guidance.sandbox-runner.ts:253,286,298,reviewer-adapter.ts:222,231,258,266,274,283,Dockerfile:7-8) against current source.🤖 Generated with Claude Code