Repository navigation
fix(js): build else branches into the CFG (#206) - #207
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #206.
The parser kept the
alternativeof anifstatement as a genericelse_clausenode. The CFG builder did not look inside it, so the statements in anelsewere never built into the CFG. Anelse ifadded no decision point, and areturnin anelsedid not end its branch.buildIfStatementnow stores the statement inside theelse_clauseasAlternate: a block, or the nextifof anelse ifchain. Nesting depth no longer needs to unwrap the clause, soisElseIfis removed.Effects:
else ifadds one to cyclomatic complexity. Onimbue-ai/latchkeytotal complexity rises from 2448 to 2463, and onsindresorhus/gotfrom 9924 to 9988. Health scores do not change on either repo.if/elsewhose branches all return is reported asunreachable_branch.elsesubtree loses one wrapper node, so clone similarity changes slightly (got: 2146 to 2139 clone pairs).