Repository navigation
fix(js): build abstract classes and class expressions as class nodes (#158) - #208
Merged
Merged
Conversation
DaisukeYoda
force-pushed
the
fix/158-abstract-class-clones
branch
from
October 15, 2026 02:17
0f169e2 to
b4e87e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #158.
The parser built only
class_declarationas a class node. Anabstract_class_declarationand a class expression fell through to the generic builder, so clone detection never offered them as class fragments.Both forms now go through the class builder: an abstract class as
NodeClass, and a class expression asNodeClassExpression. The class builder now also keepstype_parameters, so an import used only in a type parameter constraint or default is no longer reported as unused. This also applies to plain classes. The CFG builder treats a class expression like a class declaration.Effects:
imbue-ai/latchkeyclone pairs go from 203 to 204.sindresorhus/gotdoes not change.ClassDeclarationtype, so it is recorded as a named export. If no module imports it, it is reported as unused, as a plain class already is.