Repository navigation
feat(core): add clone.SplitGroupsByPairs (#173) - #209
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #173.
Adds
SplitGroupsByPairstocore/clone, next toFilterGroupsWithoutBackingPairs. It restricts each clone group to the connected components of the pairs that remain after suppression and the clone-type filter, and it recomputes each group's type and similarity from those pairs.The code and tests are moved unchanged from
polyscan/internal/js/analyzer/clone_group_split.go. After this merges andcore/v0.2.9is tagged, a follow-up PR switches polyscan to the core function and deletes the local copy. pyscn can then dropsplitDisconnectedGroupsandfilterCloneGroupsByPairs.