Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #319, which has merged.
Correct both LSP34OwnershipSource schema blocks to a pair of Bytes32 words, matching the existing canonical 64-byte abi.encode(address, bytes32) value. Clarify zero-left-padding of the address word and rejection of the 52-byte packed tuple. No key, ownership, minting-policy, or on-chain encoding change.
Verification
Both schemas extracted from the actual markdown encode/decode correctly with erc725.js 0.28.2; bytes equal independent ethers/cast ABI oracles. Four vectors per schema, old-schema failure reproduction, and 52-byte negative controls pass. Reference implementation: lukso-network/lsp-smart-contracts#1088.