Repository navigation
fix: Missing background in lukso-input - #916
Merged
Merged
Conversation
…kground on non-white surfaces
Contributor
There was a problem hiding this comment.
Pull request overview
Restores a consistent background color for lukso-input and lukso-input-date-picker when variant is unset/empty, ensuring inputs remain readable on non-white surfaces.
Changes:
- Moved
bg-neutral-100back into the base styles forlukso-input(input + unit slots). - Made
variant.defaulta no-op forlukso-input, keepingvariant.subtleas the override. - Applied the same base-background fix to
lukso-input-date-pickerand made itsvariant.defaulta no-op.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/components/lukso-input/index.ts | Ensures the base input and unit always have bg-neutral-100, independent of variant value. |
| src/components/lukso-input-date-picker/index.ts | Ensures the date-picker input base always has bg-neutral-100, with subtle still overriding. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Storybook deployed with Cloudflare Pages ☁️ 📖 🚀Storybook
Built from commit 6d75fad |
dzbo
enabled auto-merge (squash)
June 16, 2026 10:36
richtera
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket ID
DEV-16385
Description
bg-neutral-100was moved from the base input slot tovariant.defaultin commita49aa92, which broke inputs on non-white backgrounds whenvariantis unset or emptybg-neutral-100to the baseinputandunitslots inlukso-inputso background is always present regardless ofvariantvaluevariant.defaultis now a no-op;variant.subtlestill overrides tobg-neutral-97as intendedlukso-input-date-pickerwhich had the identical pattern in its owninputStyles