Repository navigation
fix: Rename logo-hub-social icon to logo-hup-social - #917
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR corrects a typo in the lukso-icon icon naming by switching the “hub” variant to “hup” across the icon implementation, registry, and Storybook docs.
Changes:
- Updated Storybook icon list entry to use
'logo-hup-social' - Updated
lukso-iconicon import andiconMapkey to the corrected name - Updated the icon function export and internal SVG
clipPathid/reference to the corrected name
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/docs/Icons.stories.ts | Updates the Storybook icon name reference to the corrected key. |
| src/components/lukso-icon/index.ts | Updates the icon import and registry key used by <lukso-icon name="...">. |
| src/components/lukso-icon/icons/logo-hup-social.ts | Renames the exported icon function and updates the SVG clipPath identifiers. |
Comments suppressed due to low confidence (1)
src/components/lukso-icon/icons/logo-hup-social.ts:30
- Renaming the exported symbol can break any consumers that deep-import this file (even if it's not the primary public API). If this package is already published, consider keeping a deprecated export alias for backward compatibility.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Storybook deployed with Cloudflare Pages ☁️ 📖 🚀Storybook
Built from commit 8deb8b7 |
JeneaVranceanu
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
logo-hub-social.ts→logo-hup-social.tsto fix a typo in the icon namelogoHubSocial→logoHupSocial'logo-hub-social'→'logo-hup-social'in the icon index