Repository navigation
Fix numeric object keys in JSON path patterns - #332
Open
bensynapse wants to merge 1 commit into
Open
bensynapse wants to merge 1 commit into
bensynapse wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I run Live Tennis API.
JSON path patterns treat numeric object keys as integers. For example,
json__0="zero"fails to match{"0": "zero"}.Keep object keys as strings during traversal. This preserves leading zeros and numeric keys inside arrays. Existing array indexing is unchanged.
Added nine cases to the existing path tests. Six fail before the fix. The JSON reference includes a mixed object and array example.
Checked the Nox test sessions on Python 3.8 through 3.14, using
nox -N -s test-3.11and the corresponding version names.Each reports 330 passed, two expected remote test skips, and 100% coverage.
nox -N -s mypy,nox -N -s docsandpre-commit run --all-filespass.Both package builds and
twine check dist/*pass.