Repository navigation
Conversation
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 293317bb60
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Codex Review: Something went wrong. Try again later by commenting “@codex review”. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Thank you for bringing TMNT up as its own target. Before we can merge, please change:
Also, the results in the description come from earlier private builds; please run this revision once on the Mac and say what you saw. |
💡 Codex Reviewhttps://github.com/ly05010419/MacNativeGames/blob/30e8b4179c4570543e2d1f68ca5b79bba8688bfc/games/tmnt/third_party/d2r_gfx/gfx/nvn/nvn_mtl.m#L12713-L12714 In the shared Mac/iPad renderer, when a full-target ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Reviewed Please address the following before merging:
Local review checks passed: 45 TMNT source/native CPU-probe tests, 15 selected shared checks scoped to the exported review tree, and Mac/iPhone SDK syntax checks of Please also update against current |
31386ca to
e8bcb3b
Compare
|
Addressed the follow-up review in
Local checks: 61 TMNT tests, 7 packaging-standard checks, 3 no-Homebrew checks, 7 work-folder checks and 10 dependency-helper checks passed, alongside selected Launcher/collector checks. The complete container build succeeded from the original NSP/keys in a nonempty work root, with fresh extraction/rewrites. A fresh-directory integration failure exposed missing NRO staging before the external link check; that ordering is fixed and regression-covered. The actual express update also passed; App inode, game hash and all signed shader-bundle bytes were preserved, and deep/strict signature verification passed. A post-launch check additionally caught the RomFS verification stamp being written inside the App; the launcher now routes it to the external profile, with a launcher regression that checks the App stays untouched. The final muted startup/exit was then repeated, and deep/strict signature verification passed afterward. Maintainer coordination still needed: please register |
Add the native host, graphics and audio integration, verified base-game build entry, shared pinned dependencies, source provenance, and Simplified and Traditional Chinese support.
Summary
Adds an experimental Apple silicon Mac host and iPadOS target for Teenage Mutant Ninja Turtles: Shredder’s Revenge, exact base 1.0.0 (
0100FE701475A000). The build verifies the player’s own NSP/XCI and keys; game data, keys, saves, generated code and translated shaders are not contributed.The Mac host now includes Simplified/Traditional Chinese catalogue support, a 1-key settings panel for frame-rate targets, input, window size/full screen and save-folder sync, and a stable
MacNativeGames/TMNTprofile. The first launch copies the newest legacy hash-named profile without overwriting stable saves or removing the original. iCloud Drive uses the shared local-copy/generation/conflict-backup model; actual cloud delivery remains the responsibility of iCloud Drive.Review changes
tools/deps.Build from the repository root:
See Mac instructions and iPad developer workflow.
Validation on this revision, 2026-11-16
Local validation: 61 TMNT tests, 7 packaging-standard checks, 3 no-Homebrew checks, 7 work-folder checks, and 10 dependency-helper checks passed. Selected Launcher, shader contribution and collector checks also passed. The Metal clear/copy pixel probe passed 256 channel comparisons; the frame-pacing probe passed 120 cases. The complete
build.pyentry succeeded from the player’s original NSP/keys in a nonempty work root, with fresh extraction/rewrites and external link validation. The installed App directory was retained.update_runtime.py --planselected an express update using that recorded work root; the actual update succeeded, preserved the game hash and every signed shader-bundle file, and passed deep/strict code-signature verification. The launcher directs the RomFS verification cache to the external profile; a post-launch seal check caught and corrected the inherited in-bundle cache write.After the complete build and express update, a final muted relaunch retained Traditional Chinese, reached the story menu and closed with exit code 0; deep/strict signature verification still passed afterward.
A muted Mac run rendered Simplified and Traditional Chinese menus, switched languages, saved the option, restarted across a runtime update, and entered chapter 1 with keyboard movement/attacks. Chapter-1 samples at the 60 target were approximately 59–61 FPS; the experimental 120 target mostly reported 119–121, with a late 107 sample around screenshot/exit. This measures submitted game frames, not proof of correct 120-FPS simulation speed or visible unique frames on every display. The earlier real-time scheduling policy was observed demoting the renderer; the host now defaults to interactive QoS. The earlier 2-second encode-drain abort did not recur in this bounded run; its complete root cause and long-session stability are not established. Original user save/account bytes remained unchanged; tests used copies.
Remaining limits / coordination
tmnt. Automatic upload is disabled until the maintainer registers TMNT in the separate website service and supplies the route. That repository was inaccessible to this contributor; no server deployment or successful upload is claimed.probe-gfxstill stops at its hard-coded TOTK NVN ABI expectation (55 versus the host’s advertised 53); it is not reported as passing. The dedicated new GPU/pacing probes above pass.Provenance and licenses
tmnt-import.jsonrecords copied-file origins/commits and current digests.COPIES.mdand the root notices retain the upstream licenses. Generated private packages carry these notices and dependency licenses.