Skip to content

fix(totk): ellipsis renders above the line, not centred - #2145

Open
lostars wants to merge 1 commit into
ly05010419:mainfrom
lostars:main
Open

lostars wants to merge 1 commit into
ly05010419:mainfrom
lostars:main

Conversation

@lostars

@lostars lostars commented Nov 13, 2026

Copy link
Copy Markdown

fix #1398

Tested and played on m4 pro v1.4.3

@ly05010419

Copy link
Copy Markdown
Owner

Thanks for the fix and for testing on 1.4.3. As #1398 says, a retail console shows the ellipsis centred with the same fonts and the same game code, so the difference is in our runtime, and choosing another face for U+2026 works around it rather than finding it. Could you look for the cause first? For example: which face the selector at main+0x10bdac0 returns for U+2026 on Ryujinx or a console compared with ours, and whether the glyph metrics (bearing, ascent) the font engine gets match. If it turns out the console does the same and the difference is elsewhere in the text path, the fix belongs there.

@lostars

lostars commented Nov 15, 2026

Copy link
Copy Markdown
Author

Thanks for the fix and for testing on 1.4.3. As #1398 says, a retail console shows the ellipsis centred with the same fonts and the same game code, so the difference is in our runtime, and choosing another face for U+2026 works around it rather than finding it. Could you look for the cause first? For example: which face the selector at main+0x10bdac0 returns for U+2026 on Ryujinx or a console compared with ours, and whether the glyph metrics (bearing, ascent) the font engine gets match. If it turns out the console does the same and the difference is elsewhere in the text path, the fix belongs there.

found the root cause and apply.

debug log:
totk.log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TOTK 1.2.1 (Mac): the CJK ellipsis renders above the line, not centred (retail console is centred)

2 participants