Repository navigation
Conversation
Let scripts consume full run statuses without parsing the human-readable table. Empty selections are JSON arrays, and the existing project filter applies.
Contributor
|
Thank you for this, @Morrow588. It's a careful, well-tested change. Another contributor had asked to take #13 on the issue and their PR covers the same ground, so we've merged #17 and I'm closing this one. Sorry for the overlap: we've added a "Picking up an issue" section to CONTRIBUTING (comment first, get assigned, then open a PR) so it doesn't happen again. If you'd like to pick up another, comment on any open good first issue and I'll assign it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Closes #13.
slm runs list --jsonprints the complete status objects as a JSON array, so scripts can consume run metadata without parsing the table. The existing--projectfilter is applied first. Empty homes and unmatched filters produce[]; the default table output is unchanged.The change serializes the existing status dictionaries rather than maintaining a second field list, preserving optional status fields. CONTRIBUTING.md includes the command and CHANGELOG.md records the new option.
Verification
Local commands used
UV_PROJECT_ENVIRONMENT=.venv-cpu UV_NO_SYNC=1; the environment uses the exported uv.lock package versions with PyTorch 2.11.0+cpu in place of the CUDA wheel because the CUDA dependency installation exceeded the sandbox disk limit. No dependency or lockfile changes are included.abc2midiwas built from its upstream source and put on PATH for the full CPU suite. OMP_NUM_THREADS=1 and MKL_NUM_THREADS=1 were set. The warning is the existing Starlette/AnyIO deprecation.All five new JSON cases fail against the original CLI (unrecognized --json) and pass with this change. Tests compare the entire decoded status objects, exercise project filtering and three empty-result cases, and retain the existing table test. The uploaded four files were compared to the tested local versions with no differences.
Checklist (CONTRIBUTING.md)