Repository navigation
feat: filter exported models by project - #20
Open
ninaad-padiyarr wants to merge 1 commit into
Open
ninaad-padiyarr wants to merge 1 commit into
ninaad-padiyarr wants to merge 1 commit into
Conversation
Use the project already recorded in export manifests so model discovery can be scoped like run discovery without changing export storage or unfiltered output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
slm models list --project NAMEnow filters exports by the manifest's top-levelprojectfield, matching how run discovery can be scoped. Without the option, the existing table and empty-store message are unchanged. An unmatched project reportsno models found for project NAME.The filter belongs in the CLI because
list_exports()already supplies the manifests; no export-storage or Project API changes are needed. Tests include the requested pair of real toy exports with different manifest owners, plus lightweight on-disk manifest coverage for exact matching, missing owners, unfiltered output, and empty stores. Command examples and the Unreleased changelog are updated.Closes #11
Checklist (CONTRIBUTING.md)
make lintandmake testpass — see local platform limits below; Linux CI is still requiredVerification
This change was checked locally on Windows/Python 3.12 with the existing CPU PyTorch installation and the remaining dependencies exported from the lockfile. The repository's CUDA index, dependency files and lockfile are unchanged.
uv run --no-sync(viaUV_NO_SYNC=1) was used for these local checks.Passed:
make lintconstituent Ruff checks:uv run ruff check .anduv run ruff format --check .(all 96 files).uv run mypy --platform linux src/slmkit(57 source files).uv run python -m compileall -q src tests, CLImodels list --help, andgit diff --check.The full CPU test command was attempted, but the existing test infrastructure requires symlink privileges and POSIX file/directory fsync and process behavior unavailable here. The external
abc2miditool is also absent. The toy-export regression is included but cannot get past the shared symlink fixture locally; a separate copy-based attempt reached the existing Windows fsync limitation. Default host-targeted mypy reports an existing Windowssignal.SIGKILLerror; the Linux-targeted check passes. No fixtures, durability checks or production platform rules were bypassed in the submitted code.makeitself is not installed on this host, so its constituent commands were run directly. Linux CI must validate the complete suite.AI assistance: OpenAI Codex assisted with implementation, review, and running validation.