Repository navigation
Conversation
| return; | ||
| } | ||
|
|
||
| bool positive_closed = !contactors->Pack_Positive_Feedback(); |
There was a problem hiding this comment.
bool positive_closed = (contactors->Pack_Positive_Feedback() == 0);
bool negative_closed = (contactors->Pack_Negative_Feedback() == 0);
bool precharge_open = (contactors->Pack_Precharge_Feedback() == 1);
is a little more readable
There was a problem hiding this comment.
This is my fault actually. I want you to readjust the conditions. Check out the PR for #600, theres a hv_shutdown condition thats sent to the dashboard that should be our condition to enter shutdown mode or not. Additionally, hv_shutdown condition comes from 1 -> 0, that means front controller has determined the accumulator states to be IDLE, so we can continue the dash state to enable precharge.
There was a problem hiding this comment.
I just pushed that signal, so pull on your side and try to use that now
summary: