Skip to content

Handle dashboard shutdown on unexpected contactor state - #608

Open
zuhaakh wants to merge 6 commits into
mainfrom
dashboard-shutdown-state
Open

zuhaakh wants to merge 6 commits into
mainfrom
dashboard-shutdown-state

Conversation

@zuhaakh

@zuhaakh zuhaakh commented Sep 28, 2026

Copy link
Copy Markdown

summary:

  • make dashboard go to SHUTDOWN when contactor state doesn't match expected HV running state
  • Display "unexpected contactor state" when a contactor mismatch causes shutdown
  • clear shutdown reason when dashboard resets

Comment thread projects/dashboard/src/Display.cpp Outdated
return;
}

bool positive_closed = !contactors->Pack_Positive_Feedback();

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bool positive_closed = (contactors->Pack_Positive_Feedback() == 0);
bool negative_closed = (contactors->Pack_Negative_Feedback() == 0);
bool precharge_open = (contactors->Pack_Precharge_Feedback() == 1);

is a little more readable

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is my fault actually. I want you to readjust the conditions. Check out the PR for #600, theres a hv_shutdown condition thats sent to the dashboard that should be our condition to enter shutdown mode or not. Additionally, hv_shutdown condition comes from 1 -> 0, that means front controller has determined the accumulator states to be IDLE, so we can continue the dash state to enable precharge.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just pushed that signal, so pull on your side and try to use that now

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants