Repository navigation
Removed DCDC_EN, DCDC_SENS_SEL, DCDC_SENS - #612
Merged
Merged
Conversation
…X, compilations checked on CLI and Vehicle
Closed
kartik-seth5
marked this pull request as ready for review
October 1, 2026 17:13
ManushPatell
self-requested a review
October 2, 2026 14:56
ManushPatell
requested changes
Oct 2, 2026
Contributor
There was a problem hiding this comment.
same goes for sil, cli and linux. Stm32 implementation looks fine
Contributor
There was a problem hiding this comment.
see how difficult it starts to become when we remove pinouts, and it requires us to change bindings from various platforms. This will soon be changed once we seperate platform agnostic code from our application code.
Contributor
|
🦅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed DCDC_EN, DCDC_SENS_SEL, DCDC_SENS, then reset PG14 with CubeMX, compilations checked on CLI and Vehicle