Repository navigation
feat: explain how to read the topic map and the document map - #54
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 26 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The topic-distance guidance is overstated, and the document-map accessibility description is inaccurate in long-text mode.
Review effort: Balanced
Findings: 1
Open (2)
What changed in this PR
Adds user-facing guidance and accessible descriptions for topic and document maps.
Changes:
- Adds explanatory accordions below both maps.
- Centralizes the 4,000-document sampling limit.
- Tests map guidance and chart descriptions.
| File | Description |
|---|---|
app.py |
Adds map guidance accordions. |
simple_topic_modeling/plots.py |
Adds guidance, descriptions, and sampling constant. |
SPECS.md |
Documents the new guidance. |
tests/test_plots.py |
Tests guidance and descriptions. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| "Document map. Each point is one document. The colour shows the dominant topic." | ||
| " Documents near each other use similar words. " + AXIS_NOTE |
There was a problem hiding this comment.
Fixed in 9c3fd02. The description now says "one document, or one segment of a long text".
| **How to read a distance.** Two topics near each other occur in documents with similar words. Two | ||
| topics far apart occur in different documents. Two circles that overlap are not the same topic. |
There was a problem hiding this comment.
Fixed in 9c3fd02. The guide now describes the distance as a tendency: a topic has most of its weight in one part of the document map, and one document can still hold two distant topics.
36c50e1 to
2e92699
Compare
a1aa27a to
9c3fd02
Compare
|
@coderabbitai review |
|
2e92699 to
d44ad26
Compare
9c3fd02 to
4d9d2bc
Compare
Each map gets a How to read accordion. The text says what a circle or a point is, how the app places it, how to read a distance, and that the axes carry no meaning. The document map text names the truncated SVD and the sample limit. Both charts get a description for assistive technology. Closes #49. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A topic position is a weighted mean over every document, so two distant topics can still share a document. The guide now says so. The document map description names the segment of a long text, as the visible guide does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EsEUVKgZPLky1kHXnU2aBW
eec339d to
8b6fac6
Compare


Summary
Closes #49.
DOCUMENT_SAMPLE_LIMIT, so the text stays true.Test
Stack
chore/deps→maintest/notebook-gatefeat/topic-numbersfeat/map-explanationsfeat/zip-figureschore/release-prepMerge from the bottom up.
🤖 Generated with Claude Code
https://claude.ai/code/session_01EsEUVKgZPLky1kHXnU2aBW