Skip to content

feat: explain how to read the topic map and the document map - #54

Merged
maehr merged 2 commits into
mainfrom
feat/map-explanations
Oct 6, 2026
Merged

maehr merged 2 commits into
mainfrom
feat/map-explanations

Conversation

@maehr

@maehr maehr commented Oct 6, 2026 •

Copy link
Copy Markdown
Owner

Summary

Closes #49.

  • The Overview tab gets a How to read the topic map accordion below the map.
  • The Documents tab gets a How to read the document map accordion below the map.
  • The texts say what a circle or a point is, how the app places it, how to read a distance, and that the axes carry no meaning.
  • The document map text names the truncated SVD and the sample limit of 4,000 documents. The limit is now the constant DOCUMENT_SAMPLE_LIMIT, so the text stays true.
  • Both charts get a description for assistive technology.

Test

  • Unit tests check the axis note, the limit, and the descriptions.
  • Browser test: the accordion opens and shows the text.

Stack

  1. chore(deps): refresh the lockfile for marimo 0.25 #51 chore/deps → main
  2. test: run the notebook with a fitted result #52 test/notebook-gate
  3. feat: show the topic number on each bubble #53 feat/topic-numbers
  4. feat: explain how to read the topic map and the document map #54 feat/map-explanations
  5. feat: add the figures to project.zip #55 feat/zip-figures
  6. chore: delete PLAN.md #56 chore/release-prep

Merge from the bottom up.

🤖 Generated with Claude Code

https://claude.ai/code/session_01EsEUVKgZPLky1kHXnU2aBW

Copilot AI balanced review requested due to automatic review settings October 6, 2026 12:29
@coderabbitai

coderabbitai Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 26 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 2ca633a3-92ed-47a8-9d13-16ddd91c14ef
📥 Commits

Reviewing files that changed from the base of the PR and between 7cd3af4 and 8b6fac6.

📒 Files selected for processing (4)
  • SPECS.md
  • app.py
  • simple_topic_modeling/plots.py
  • tests/test_plots.py
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The topic-distance guidance is overstated, and the document-map accessibility description is inaccurate in long-text mode.

Review effort: Balanced
Findings: 1 Medium severity · 1 Low severity

Open (2)
What changed in this PR

Adds user-facing guidance and accessible descriptions for topic and document maps.

Changes:

  • Adds explanatory accordions below both maps.
  • Centralizes the 4,000-document sampling limit.
  • Tests map guidance and chart descriptions.
File Description
app.py Adds map guidance accordions.
simple_topic_modeling/​plots.py Adds guidance, descriptions, and sampling constant.
SPECS.md Documents the new guidance.
tests/​test_plots.py Tests guidance and descriptions.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread simple_topic_modeling/plots.py Outdated
Comment on lines +512 to +513
"Document map. Each point is one document. The colour shows the dominant topic."
" Documents near each other use similar words. " + AXIS_NOTE

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 9c3fd02. The description now says "one document, or one segment of a long text".

Comment thread simple_topic_modeling/plots.py Outdated
Comment on lines +73 to +74
**How to read a distance.** Two topics near each other occur in documents with similar words. Two
topics far apart occur in different documents. Two circles that overlap are not the same topic.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 9c3fd02. The guide now describes the distance as a tendency: a topic has most of its weight in one part of the document map, and one document can still hold two distant topics.

@maehr
maehr force-pushed the feat/topic-numbers branch from 36c50e1 to 2e92699 Compare October 6, 2026 12:35
@maehr
maehr force-pushed the feat/map-explanations branch from a1aa27a to 9c3fd02 Compare October 6, 2026 12:35
@maehr

maehr commented Oct 6, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@maehr
maehr force-pushed the feat/topic-numbers branch from 2e92699 to d44ad26 Compare October 6, 2026 12:57
@maehr
maehr force-pushed the feat/map-explanations branch from 9c3fd02 to 4d9d2bc Compare October 6, 2026 12:57
Base automatically changed from feat/topic-numbers to main October 6, 2026 13:00
maehr and others added 2 commits October 6, 2026 15:02
Each map gets a How to read accordion. The text says what a circle or a point is,
how the app places it, how to read a distance, and that the axes carry no meaning.
The document map text names the truncated SVD and the sample limit. Both charts get
a description for assistive technology.

Closes #49.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A topic position is a weighted mean over every document, so two distant topics can
still share a document. The guide now says so. The document map description names the
segment of a long text, as the visible guide does.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EsEUVKgZPLky1kHXnU2aBW
@maehr
maehr force-pushed the feat/map-explanations branch from eec339d to 8b6fac6 Compare October 6, 2026 13:02
@maehr
maehr merged commit 27132db into main Oct 6, 2026
6 checks passed
@maehr
maehr deleted the feat/map-explanations branch October 6, 2026 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request: Improve explanations for Topic Map and Document Map

2 participants