fix: stop empty output from containers wrongly treated as hidden - #97
Merged
Merged
Conversation
…and fall back to hidden content rather than return empty output
hownowstephen
marked this pull request as ready for review
September 26, 2026 17:04
…tent option for callers to retry with
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some email layouts converted to an empty string, which SendGrid rejects with a 400. The hidden-content check dropped entire subtrees for styles that don't actually hide them:
font-size:0is inherited and reset by descendants (the inline-block gap fix that often wraps a whole layout), so it's no longer treated as hidden.max-height:0only hides withoverflow:hidden, so it now requires both.Hiding is still a guess from inline styles, so this adds
WithHiddenContent()to keep hidden content. Callers that need text can retry with it whenConvertreturns empty; the library doesn't retry on its own.