Skip to content

Chat on Windows: Claude Code's session under the pane's shell (from #113) - #118

Merged
makefunstuff merged 11 commits into
mainfrom
puchedev/windows-chat
Nov 8, 2026
Merged

makefunstuff merged 11 commits into
mainfrom
puchedev/windows-chat

Conversation

@makefunstuff

Copy link
Copy Markdown
Owner

puchedev's #113, carried on our branch: their commits plus main merged in. #111 is already squash-merged, so this resolves the one conflict in SearchScreen.kt by keeping #113's newer version (ChatSearch.commands, several commands that each fit Windows' command line). Core tests pass and the app compiles locally.

The security review (HERD-34) found #113 clean: on Windows the one new call is a fixed powershell.exe process-table read, and the grep fallback passes the search word to awk through ENVIRON, never inside the program text.

Closes #113.

🤖 Generated with Claude Code

puchedev and others added 11 commits November 7, 2026 21:09
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Search lists herdr-core's workspaces now, but only classic herdr opens a
terminal from the phone, so the button failed there. The Spaces screen
already left it out.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…i with -F

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…once per chat

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Windows hands the command to Git's bash on a line cut at 8191 characters
(each double quote counting twice), and a cut command fails whole. A
machine with more agents than fit gets its search in more than one
command, run one after another, so no chat is skipped. The process table
is read once per command even when PowerShell gives nothing back.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts:
#	app/src/main/kotlin/com/makefunstuff/herdr/ui/search/SearchScreen.kt
@makefunstuff
makefunstuff merged commit 9f71127 into main Nov 8, 2026
12 checks passed
@makefunstuff
makefunstuff deleted the puchedev/windows-chat branch November 8, 2026 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants