Repository navigation
HERD-35 Wide-screen sidebar switches to the tapped space (#101) - #119
Merged
makefunstuff merged 2 commits intoNov 8, 2026
Merged
Conversation
Picking a space went to the Chat tab with restoreState, which brought back whatever the tab had open over its own screen (the last space's terminal or chat): on a wide window, where the sidebar is beside any screen, the pick seemed to do nothing but mark the space. Picking now shows the Chat tab's own screen and drops the screens it had open. The wide-pick preview scene checks it: Chat, its Terminal, then website in the sidebar must show website's chat. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… shots Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a wide window (an unfolded Pixel Fold, a tablet), tapping a space in the sidebar now opens that space's chat. Before, if the Chat tab had a screen open over its chat (a terminal, say), the tap only marked the space as selected and the old screen stayed. So it looked like nothing happened.
Fixes #101
Cause. Picking a space went to the Chat tab with
restoreState, which brought back what the tab had open over its own screen. On a phone the drawer only opens over a tab's own screen, so this never showed there. The sidebar on a wide window sits beside any screen. Picking a space now shows the Chat tab's own screen and drops what it had open (showSpace()inAppNav.kt). The sidebar's other entries (a machine, Search, Settings, Add machine) push their screen and already worked.Test. New preview scene
wide-pick(Chat → Terminal → website in the sidebar). It checks that website's chat shows and the terminal is gone. It fails on main and passes here. Not covered by a test: picking a space from another tab while the Chat tab kept a screen. The fix clears that saved screen too, but the preview has no tap that reaches that path.Shots (
wide-pick, before → after)Checks:
./gradlew -p core test,./gradlew :app:testDebugUnitTest, and a render of wide, wide-empty, wide-machines, wide-pick, rotate-wide, rotate-narrow and settings, all in both themes.Task: HERD-35
🤖 Generated with Claude Code