Skip to content

Fix image links with optional titles - #61

Open
jay23606 wants to merge 1 commit into
mapitman:mainfrom
jay23606:fix/preserve-markdown-image-title
Open

jay23606 wants to merge 1 commit into
mapitman:mainfrom
jay23606:fix/preserve-markdown-image-title

Conversation

@jay23606

Copy link
Copy Markdown

Summary

  • Parse the image destination separately from an optional CommonMark title before embedding relative images.
  • Preserve double-quoted, single-quoted, and parenthesized titles so Goldmark renders the image title attribute.
  • Add regression coverage for titled and untitled relative images.

Fixes #60.

Validation

  • go test -vet=off ./... passes. The repository baseline currently fails go vet because main.go:187 passes a redundant newline to fmt.Println; the same warning occurs on clean main.
  • go build ./... passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Image link with a title fails to resolve the image path

2 participants