Skip to content

pack.mjs: find the tarball by the new file, not by the JSON output of pnpm #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mark1russell7 merged 1 commit into from
Oct 17, 2026
Merged

pack.mjs: find the tarball by the new file, not by the JSON output of pnpm #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions scripts/release/pack.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
// specifier, because npm users cannot install that package.

import { execFileSync } from "node:child_process";
import { mkdirSync, writeFileSync } from "node:fs";
import { mkdirSync, readdirSync, writeFileSync } from "node:fs";
import { basename, join, resolve } from "node:path";
import { publishedPackages, unpublishableDependencies } from "./workspace.mjs";

Expand All @@ -34,12 +34,13 @@ if (blocked.length > 0) {
const shell = process.platform === "win32";
const lines = [];
for (const { dir, manifest } of packages) {
const packed = execFileSync("pnpm", ["pack", "--json", "--pack-destination", resolve(out)], {
cwd: dir,
encoding: "utf8",
shell,
});
const file = basename(JSON.parse(packed).filename);
// The new file in the folder is the tarball. The output of pnpm is not used: it also holds the
// output of the package scripts that pnpm pack starts (prepare, prepack).
const before = new Set(readdirSync(out));
execFileSync("pnpm", ["pack", "--pack-destination", resolve(out)], { cwd: dir, stdio: ["ignore", "inherit", "inherit"], shell });
const added = readdirSync(out).filter((name) => !before.has(name) && name.endsWith(".tgz"));
if (added.length !== 1) throw new Error(`pnpm pack of ${manifest.name} made ${added.length} tarballs: ${added.join(", ")}`);
const file = basename(added[0]);
lines.push(`${manifest.name} ${manifest.version} ${file}`);
process.stdout.write(`${manifest.name}@${manifest.version}: ${file}\n`);
}
Expand Down
Loading