Repository navigation
Conversation
Newer Scriban source uses trimming attributes (DynamicallyAccessedMembers etc.) that don't exist on netstandard2.0.
yvanlo
force-pushed
the
deps/bump-scriban
branch
from
September 21, 2026 07:50
34709cb to
f8a5684
Compare
This was referenced Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scriban 7.0.0 has known advisories, reported as NuGet audit warnings when building the source generator:
All are fixed in 7.2.2+. This bumps Scriban to the latest version, 7.4.0.
Mediator only renders its own embedded templates, so the practical risk is low, but the audit warnings go away.
Build fix
Since 7.2, the Scriban source uses trimming attributes (
DynamicallyAccessedMembers,UnconditionalSuppressMessage,RequiresUnreferencedCode, ...) that don't exist on netstandard2.0. PolySharp doesn't generate these by default, so I enabledPolySharpIncludeRuntimeSupportedAttributes.Testing
dotnet buildof the solution: 0 errorsdotnet test:Mediator.Tests,Mediator.Telemetry.TestsandMediator.MemAllocationTestspassMediator.SourceGenerator.Tests: 187/190 pass. TheSampleTestsgo from 8 failures onmainto 3 on this branch (on my machine). The 3 remaining failures are NuGet audit warnings from other sample packages (Microsoft.OpenApi2.0.0,OpenTelemetry.*1.15.0), not related to this change.