Skip to content

docs/ci: add production DNP3 engineering contract and PR build gate - #1

Merged
masarray merged 3 commits into
masterfrom
chore/agent-engineering-contract-v6
Sep 10, 2026
Merged

docs/ci: add production DNP3 engineering contract and PR build gate#1
masarray merged 3 commits into
masterfrom
chore/agent-engineering-contract-v6

Conversation

@masarray

Copy link
Copy Markdown
Owner

Summary

Strengthens DNPTester governance without changing protocol/runtime behavior.

Changes

  • adds a root repository engineering contract so repo/release/workflow rules are visible before entering the app subtree
  • strengthens Dnp3MasterTester/AGENTS.md with root-cause-first workflow, typed Result/Try failure handling, bounded diagnostics, explicit state ownership, UI backpressure, resource lifecycle, and regression discipline
  • adds a Windows/.NET 8 pull-request build gate for the main application without packaging/publishing

Key protections

  • transport-open is never treated as proof of DNP3 response
  • malformed/partial protocol data fails explicitly instead of being guessed into values
  • routine protocol/runtime conditions use typed status/results rather than exception-driven control flow
  • high-rate callbacks do not synchronously mutate unbounded WPF collections
  • diagnostics are bounded, aggregated/rate-limited, and cannot stall protocol progress
  • command lifecycle, point-cache, event/SOE timestamp, and evidence/report invariants remain authoritative

No product feature behavior is intentionally changed.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7df21545a7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/ci.yml
Comment on lines +5 to +9
branches:
- master
push:
branches:
- master

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Trigger the build gate for the main branch

The repository's active integration branch is main—the reviewed commit's parent is the main tip, and the existing Pages workflow also listens to main—but both event filters select only master. Consequently, pull requests targeting main and pushes to main never schedule this job, so the advertised application build gate provides no protection; include main or target the actual default branch.

AGENTS.md reference: AGENTS.md:L20-L24

Useful? React with 👍 / 👎.

@masarray
masarray merged commit c636b43 into master Sep 10, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant