M1: make COMTRADE open native-only - #305
Draft
masarray wants to merge 30 commits into
Draft
Conversation
masarray
changed the base branch from
main
to
fix/fat-workstation-convergence
September 13, 2026 23:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
fix/gui-ux-comtrade-inprocess-m1COMTRADE workstation provenance
The rich viewer restored here comes from ARSAS commit
c3e2ac3ef6e6a3a49f47c5155a0ba4a7c00bcb6b(P1D.7: integrate production COMTRADE workstation). It restores the ARSAS-native engineering surfaces that were lost when the FAT branch evolved separately:The analysis engine is deliberately pinned to the field-tested ArdIrec bridge snapshot used by that workstation, not ArdIrec latest/main:
masarray/ardirecfeat/p1d5-arsas-analysis-bridge7dbc7149db668126a493ce338264363a6ec5ec00Preserved native-only guards
ardirec.exelaunchProcess.StartCOMTRADE fallbackFaultRecordWindow.ComtradeOpen.csremains routed toArdIrecNativeBridge.TryOpen+ComtradeWorkspaceWindowEarlier UX fixes retained
Current integration commits
26cacbac0357477b7a14c8b08d999ed763c30ce4— restore field-accepted COMTRADE workstation782a3249385d3923336b2e2567bcca8b3c24b02b— validate field-tested ArdIrec analysis pin962f79dcab6c08180fc408b097d5b76e8a538e4b— align installer validation with field-tested COMTRADE pinValidation
GitHub Actions for current head
962f79dcab6c08180fc408b097d5b76e8a538e4bhave been triggered. At the latest check the runners are still queued, so this PR remains Draft and no green claim is made for the new transplant yet.