Chore/sanitize sensitive config 20260814 - #380
Merged
Merged
Conversation
Updated the filtering logic in AlarmHistoryQueryHandler, AlarmRuleQueryHandler, and WebHookQueryHandler to perform case-insensitive searches by converting both the filter and the target display names to lowercase. This enhancement ensures more accurate search results regardless of the case used in the input.
Remove hardcoded credentials from tracked configuration files and switch design-time database config loading to optional local secrets plus environment variables to satisfy repository secret scanning. Co-authored-by: Cursor <cursoragent@cursor.com>
- Deleted the Masa.Alert.Web.Admin project, including all related components and files. - Updated solution and project files to remove references to the deleted project. - Added support for appsettings.secrets.json in PostgreSQL and SQL Server projects to manage sensitive configurations. - Commented out the ITokenGenerater registration in the service configuration to prevent potential issues. This refactor streamlines the project structure and enhances configuration management.
Removed a commented-out entry in appsettings.json to enhance clarity and maintainability of the configuration file.
Replaced placeholder values for DCC_SECRET and ADMIN_PWD with actual credentials. Updated Redis and PostgreSQL connection settings to reflect new server addresses and ports, enhancing the application's configuration for the development environment.
Uncommented the registration of ITokenGenerater in the service configuration to ensure proper token generation functionality is available in the application.
Qinyouzeng
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.