Repository navigation
deps: replace chrono-english with interim - #9
Open
josefbacik wants to merge 1 commit into
Open
josefbacik wants to merge 1 commit into
josefbacik wants to merge 1 commit into
Conversation
chrono-english is unmaintained and carries an unfixed security advisory. interim is its maintained fork with the same API surface, so the only code change is the crate path in parse_date(). It is pulled in with the chrono_0_4 feature so the existing chrono::DateTime<Utc> call site works unchanged, and the test suite in date_utils covers the same inputs. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chrono-englishis unmaintained (upstream issue) and carries an unfixed security advisory. The recommended migration path isinterim, a maintained fork with the same API surface.Cargo.toml, enabling thechrono_0_4feature so our existingchrono::DateTime<Utc>call site works unchanged.parse_date()insrc/date_utils.rs, plus comment updates.interimalso drops thescanlextransitive dep in favor oflogos.Test plan
cargo fmtcleancargo clippy --all-targets -- -D warningscleancargo testpasses (228 lib tests + integration tests), including the 9date_utilstests coveringyesterday,today,N days/weeks/months ago, ISO dates, and invalid input🤖 Generated with Claude Code