10 countrys - #2332
Conversation
notbelievable
commented
Aug 20, 2026
notbelievable
commented
- DEMO LINK
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your implementation is mostly solid, but there's a critical missing requirement. The task explicitly requires validating that strings can be converted to numbers before calling Number(). Currently, Number() is called directly on population values without any isNaN() check or similar validation. This means invalid or empty values could cause issues with your calculations. Add a validation step to ensure the parsed value is a valid number before adding it to your total count, as this is a core functional requirement specified in the task description. Once you add this validation, your solution should be ready for approval.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| let count = 0; | ||
|
|
||
| for (const country of listCountrys) { | ||
| count += Number(country.textContent.replaceAll(',', '')); |
There was a problem hiding this comment.
The task requires validating that the string can be converted to a number before conversion. Currently, Number() is called directly without validation. Consider using isNaN() or a similar check to ensure the parsed value is a valid number before adding it to the count.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Here is my approval: your implementation meets all core requirements and functions correctly. You properly select the population spans, validate inputs with an isNaN() check before conversion, compute both total and average, and replace the placeholder text as specified. The use of toLocaleString() for thousands separators ensures clear, locale-aware formatting of the results. I did not observe any critical blockers or missing features for the described task. As a minor improvement, you could guard against empty NodeLists or handle edge cases like negative values if those are out of scope, but these are optional refinements. Nice work bringing everything together cleanly and correctly.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
