Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix CI
TestingandBuild DocsProblem:
boltztrap2<25.11.1was pinned with an upper bound, added earlier to work around acompilation issue when installing via pip. That bound now forces an old release. The old releases
bundle spglib 1.9.9, whose CMake project declares a minimum version below 3.5. CMake 4 rejects
that, so the install fails with
Compatibility with CMake < 3.5 has been removed.Fix: Remove the upper bound and use the latest release,
26.3.1. It bundles spglib 2.6.0 and builds with CMake 4.
Check URLsProblem: The Materials Project website is behind Cloudflare, which blocks automated requests.
The link checker gets
403 Forbiddenfor the workingmaterialsproject.organdnext-gen.materialsproject.orglinks, so the job fails.Fix: Accept
403in the link checker. Genuinely broken links (e.g.404) are still reported.