Repository navigation
Enable AgentID linking in production (+ fix put-secrets.sh empty-array bug) - #188
Merged
Merged
Conversation
… bug - wrangler.toml: set the production [vars] to turn AgentID on — AGENTID_ENABLED=1, AGENTID_CLIENT_ID (public client id for the registered 'BasedAgents' AgentID client), AGENTID_REDIRECT_URI=https://api.basedagents.ai/v1/agentid/callback. ISSUER/SCOPES stay implicit (code defaults: https://auth.agentid.com, 'openid email profile'). The feature still fails closed until the AGENTID_CLIENT_SECRET wrangler secret is set, so GET /v1/status -> agentid flips to 'enabled' only once that secret is present. - put-secrets.sh: fix 'WRANGLER_ENV_ARGS[@]: unbound variable' on bash 3.2 (macOS) under set -u when no --env is passed (production path). Use the empty-array-safe expansion ${arr[@]+"${arr[@]}"}. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NNqTSRyDjL1LcayDuUeDkr
|
🔎 Console preview: https://b841fc8f.basedagents-console.pages.dev (Passkey ceremonies only work on app.basedagents.ai — previews are for UI review.) |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Turns the (already-merged, #170) AgentID verified-identity feature on in production, and fixes a bug in the secret-setup script hit while doing so.
packages/api/wrangler.toml— production[vars]AGENTID_ISSUER/AGENTID_SCOPESstay implicit (code defaults:https://auth.agentid.com,openid email profile).scripts/put-secrets.shFixes
WRANGLER_ENV_ARGS[@]: unbound variable— on macOS bash 3.2 underset -u, expanding the empty array (the no---env/production path) errors. Switched to the empty-array-safe${arr[@]+"${arr[@]}"}expansion. Verified: empty →put NAME;--env staging→put NAME --env staging.agentidto flip toenabledThis PR sets the vars only. The feature fails closed until the
AGENTID_CLIENT_SECRETwrangler secret is present on theagent-registry-apiworker:(An empty value was accidentally uploaded earlier; it must be overwritten with the real one.) Also ensure the registered client lists
https://api.basedagents.ai/v1/agentid/callbackas an allowed redirect URI.Verify after merge + deploy
🤖 Generated with Claude Code
https://claude.ai/code/session_01NNqTSRyDjL1LcayDuUeDkr
Generated by Claude Code