Skip to content

fix: rebuild the content banks, so the Module Reward cards carry the design's current words - #615

Merged
maximsan merged 1 commit into
mainfrom
fix/module-reward-copy-stale-bank
Sep 16, 2026
Merged

maximsan merged 1 commit into
mainfrom
fix/module-reward-copy-stale-bank

Conversation

@maximsan

Copy link
Copy Markdown
Owner

Why

Auditing #75 and #368 against the code turned up a shipping defect and a red
main. 4beb98b2 chore: update prototype sources rewrote the five module
rewards in the design and nobody re-ran the extractor, so the banks on disk —
and the card a learner earns for finishing a module — still carried the
previous summary and fact. Rebuilt from the prototype.

Watch for

  • Only modules.json moves. The same commit also touched data.jsx,
    brew-challenge.jsx, dictionary-data.jsx, customize.jsx and
    screens.jsx, but everything the extractor reads out of them is unchanged —
    those diffs are interaction and layout, which belong to design parity (Design parity: the master checklist #365),
    not to a bank.
  • The words are the design's, not mine. The banks are generated output; the
    diff is whatever node tool/extract_content.js writes.
  • The gate that catches this already existed and did its job — the committed banks match a fresh extraction has been failing the
    analyze & test job since that commit. Nothing new is added to watch for it.

Checks

  • flutter test — 3227 pass; the bank test is green again.

…design's current words

The prototype's five module rewards were rewritten in 4beb98b and the
extractor was never re-run, so the banks on disk — and the cards a learner
earns from them — still carried the previous summary and fact. Rebuilt with
'node tool/extract_content.js'; only modules.json moves.

This also turns main green: 'the committed banks match a fresh extraction'
has been failing the 'analyze & test' job since that commit.
@maximsan
maximsan merged commit 2904739 into main Sep 16, 2026
7 checks passed
@maximsan
maximsan deleted the fix/module-reward-copy-stale-bank branch September 16, 2026 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant