Roasty's lines ship as a bank, so a language folder can reach them - #617
Merged
Merged
Conversation
The lines were read straight off rootBundle, bypassing the bank loader and the language overlay, so no language folder could translate them. They now load through loadBank like every other content file. One record per line, each with an id of its own: a language fills the same slots English has, and fixing an English typo sends only that line back for re-reading rather than its neighbours (#604). Still owed: the ROASTY_LINES declaration in the prototype, and the regenerated bank that comes from it.
The 18 lines move from a hand-authored asset into ROASTY_LINES in customize.jsx, where the extractor reads them like every other bank. The old assets/content/companion_lines.json is gone; the generated bank replaces it, so a language folder reaches Roasty for the first time. Same words, same counts per occasion — only ids and the occasion field are new (#604).
2 tasks
23 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Roasty's lines were the one piece of reader-facing prose no language folder
could reach — read straight off
rootBundle, bypassing the bank loader and thelanguage overlay every other content file goes through. Closes #604, which
blocks every language shipping.
Watch for
prototype/customize.jsxnow, by the owner. Abank's master comes from the extractor and there is no non-prototype bank
source, so that is where they had to go. Same 18 lines, same counts per
occasion — only the ids and
occasionare new.record per line, so fixing an English typo re-stales that line and not its
neighbours; the cost is that a translator cannot ship fewer. The alternative —
one list per occasion — buys length freedom and loses the per-line review
marks ADR-0026 exists for.
occasionthrows. A line that can never be spoken is a builddefect, and a companion that quietly says less is indistinguishable from one
with fewer lines authored.
owned_term.g.dartis regenerated and unrelated. Pre-existing drift onmain — the committed output no longer matched the generator. Doc-comment text
only, no behaviour.
Checks
Smoke suite run locally, since it gates main rather than PRs and this moves
content loading at startup.