Conversation
`Semantics(button: true, excludeSemantics: true)` reads a tappable row as one announcement, but the exclusion drops the child's tap action along with its text. What is left says "button" and carries nothing to press. Twenty-seven nodes were in that state, not the nine the ticket names: the shared frame and replay row cover the drill rows it lists, and match_tile rather than match_board_view holds the tile. The handler now goes on the Semantics as well as the child. Where the exclusion is conditional — Disclosure, ProfileCard — the tap is carried only when the child's own is being dropped. Passing it beside a live InkWell splits the row into two nodes and takes the button flag off the one that carries the label. A guard test reads every source under lib/ and fails if the flag and the action come apart again, and BorderedTapRow has a widget test that performs the announced action and checks the handler runs. Closes #487
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Closes #487. Nodes flagged
isButtoncarried no tap action, so VoiceOver andTalkBack announced buttons that did nothing when activated.
Watch for
named the wrong file: the drill rows are
ReplayRow, the tile ismatch_tile.dart, andpath_module_section.darthas no button at all — itsexcluded node is a label rewrite. The new guard test found the true set.
DisclosureandProfileCardtake the tap conditionally. TheirexcludeSemanticsis itself conditional, and passingonTapbeside a liveInkWellturns the annotation into a node boundary: the row splits in twoand the button flag lands on the node that does not carry the label. An
existing assertion in
help_support_screen_test.dartcaught that.announced
button: truewhile its lesson id was still unresolved, so it hadnothing to press even after the tap was passed. It is now a button only once
there is an id.
write-time hook, so a touched file would not save until it was clean. Design
rationale was cut rather than moved;
reward_row,challenge_offer_rowandsound_togglelost the most, and it may belong indocs/. I also dropped acitation of ADR-0005 for "peak intent" — that ADR is about mini-games and
the phrase is in
docs/design/PRODUCT.md.Checks
The widget test performs the announced action and asserts the handler runs,
rather than only checking the flag. The guard reads source text, so it pairs
the flag with the action but cannot see that a handler is nullable — that
pairing is still by hand. No real VoiceOver or TalkBack pass was made, and
nothing on screen changes.