[feat] Stale old alerts on line diagram banner#3281
Open
lvachon1 wants to merge 5 commits into
Open
Conversation
joshlarson
requested changes
Jun 26, 2026
joshlarson
left a comment
joshlarson
left a comment
Contributor
There was a problem hiding this comment.
Left a few comments - one is stylistic, the other is functional, but they're both blocking me from approving.
Also, I know the ticket mentions GL and GL-E, but this solution applies to any line diagram page (which I think is good), so I would also update the PR title (and thus the commit message when it gets merged) to not be GL/GL-E specific.
lvachon1
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Asana Ticket: 🐬 Stale Symphony alert on line diagram banner on GL and GL-E pages
Implementation
Added filter to remove alerts older than five weeks from the line diagram page.
Interestingly the Symphony alert has been downgraded in priority and no longer shows on the line diagram anyway.
Screenshots
How to test
http://localhost:4001/schedules/Green-C/line
The Tappan Street alert is older than 5 weeks old and a high priority alert, confirm that it no longer shows on the line diagram page.