Skip to content

Update dependencies, fix compiler-breaking typo#2

Merged
lilybarrett merged 3 commits into
mbta:masterfrom
lilybarrett:update_cowboy_version
Jun 22, 2026
Merged

Update dependencies, fix compiler-breaking typo#2
lilybarrett merged 3 commits into
mbta:masterfrom
lilybarrett:update_cowboy_version

Conversation

@lilybarrett

@lilybarrett lilybarrett commented Jun 18, 2026

Copy link
Copy Markdown

We initially ran into issues incorporating Laboratory in an application that depends on a later version of cowboy. This PR does the following:

  • Removes direct invocation of cowboy in favor of plug-cowboy
  • Updates to a more modern Elixir version
  • Minimally adds a few more modern touches to other code
  • Fixes a typo in mix.exs that broke the compiler (referencing package instead of package().)

Also worth noting: We currently have different sources of truth for the Laboratory library across different MBTA applications. For instance, AlertsViewer uses a branch of Paul's personal fork, and DotCom uses a branch of my personal fork. The MBTA's fork is currently very out of date compared to both of these!

Hopefully, with the PR changes, the MBTA's fork can become the sole repo used for Laboratory.

Lily Barrett added 3 commits June 16, 2026 15:42
@lilybarrett

lilybarrett commented Jun 18, 2026

Copy link
Copy Markdown
Author

@arkadyan @paulswartz I closed the original PR to Paul's fork, and opened this one so that the changes will be reflected in the MBTA's Laboratory fork.

@arkadyan arkadyan left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@arkadyan

Copy link
Copy Markdown

@lilybarrett With this change, can we migrate dotcom to use this library source?

@lilybarrett

lilybarrett commented Jun 22, 2026

Copy link
Copy Markdown
Author

@lilybarrett With this change, can we migrate dotcom to use this library source?

Yes, definitely! I plan to make another PR to update this in Dotcom once we merge this.

UPDATED: PR for Dotcom is here: mbta/dotcom#3278

@lilybarrett lilybarrett merged commit 9a2afb6 into mbta:master Jun 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants