Update dependencies, fix compiler-breaking typo#2
Merged
Conversation
added 3 commits
June 16, 2026 15:42
Trying something
Update more deps
Author
|
@arkadyan @paulswartz I closed the original PR to Paul's fork, and opened this one so that the changes will be reflected in the MBTA's Laboratory fork. |
|
@lilybarrett With this change, can we migrate dotcom to use this library source? |
Author
Yes, definitely! I plan to make another PR to update this in Dotcom once we merge this. UPDATED: PR for Dotcom is here: mbta/dotcom#3278 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We initially ran into issues incorporating Laboratory in an application that depends on a later version of cowboy. This PR does the following:
cowboyin favor ofplug-cowboymix.exsthat broke the compiler (referencingpackageinstead ofpackage().)Also worth noting: We currently have different sources of truth for the Laboratory library across different MBTA applications. For instance, AlertsViewer uses a branch of Paul's personal fork, and DotCom uses a branch of my personal fork. The MBTA's fork is currently very out of date compared to both of these!
Hopefully, with the PR changes, the MBTA's fork can become the sole repo used for Laboratory.