feat: removing 120 min limit cutoff#1823
Conversation
| typicality = RoutePattern.Typicality.Typical | ||
| representativeTrip { headsign = "Typical Out" } | ||
| } | ||
| // should not be included because not typical and prediction beyond 120 minutes |
There was a problem hiding this comment.
suggestion: this comment should be updated as well to reflect that it should be shown (or the comment can just be removed)
There was a problem hiding this comment.
That's right, I'll update it
| val predictionPastPrediction = | ||
| objects.prediction { | ||
| stopId = stop1.id | ||
| stopId = stop2.id |
There was a problem hiding this comment.
issue: I think it is important that this is stop1 so that we can assert that predictions for this stop in the past are not shown. I do think there is an important comparison against now that we need to preserve to ensure past predictions are filtered out (and I'm wondering now how there isn't an existing user facing issue on StopDetailsFiltered and Favorites where cutoff time is already null 🤔)
There was a problem hiding this comment.
I need to revisit this, I was running on the assumption that this code was running after my change, but it shouldn't.
I thought that the reason why this was showing up was because the stopId in the prediction was the same as in the vehicleId. I guess after my change validation is gone and it would show predictions in the past that don't match prediction.stopId == vehicle.stopId
2 participants
Summary
Ticket: Nearby - remove 120 min cutoff
What is this PR for?
Removing the 120 min limit cutoff for trips that are schedule over 120 minutes can be displayed in the app
iOS
android
withContext(Dispatchers.Default)where possible (ideally in shared code)Testing
What testing have you done?