Repository navigation
mcpl_split drops USERVARS blocks a part does not use - #395
Merged
Merged
Conversation
With remove_unused_parameters, each part of a split instrument now also loses the USERVARS blocks declaring only names nothing in it mentions -- in its code, its components' code, or quoted in a parameter, the MCPL components' included. Before, the primary of an instrument kept the particle variables of whatever sample followed it, so the same primary spectrometer hashed differently for every sample declaring its own, and restage simulated it again for each. A block whose declarations can not be read is kept.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
remove_unused_parameters, each part of a split instrument now also loses theUSERVARSblocks declaring only names nothing in it mentions -- in its code, its components' code, or quoted in a parameter, the MCPL components' included. Before, the primary of an instrument kept the particle variables of whatever sample followed it, so the same primary spectrometer hashed differently for every sample declaring its own, andrestagesimulated it again for each. A block whose declarations can not be read is kept.