Skip to content

Read a component CATEGORY given as a bare name #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
g5t merged 2 commits into from
Oct 18, 2026
Merged

Read a component CATEGORY given as a bare name #397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
046b4d5
Read a component CATEGORY given as a bare name
g5t Oct 18, 2026
b807cb7
Merge branch 'main' into category-identifier
g5t Oct 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/mccode_antlr/comp/visitor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ def visitComponentDefineCopy(self, ctx: Parser.ComponentDefineCopyContext):

def visitCategory(self, ctx: Parser.CategoryContext):
# Return the provided identifier or string literal, minus quotes
self.state.category = str(ctx.StringLiteral())[1:-1] if ctx.Identifier() is None else str(ctx.Identifer())
self.state.category = str(ctx.StringLiteral())[1:-1] if ctx.Identifier() is None else str(ctx.Identifier())

def visitComponent_define_parameters(self, ctx: Parser.Component_define_parametersContext):
for parameter in self.visit(ctx.component_parameters()):
Expand Down
10 changes: 10 additions & 0 deletions tests/test_comp_category.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
"""A component's CATEGORY may be a bare name or a quoted string."""
import pytest

from mccode_antlr.comp import Comp


@pytest.mark.parametrize('category', ['samples', '"samples"'])
def test_category_is_read_either_way(category):
source = f'DEFINE COMPONENT T\nSETTING PARAMETERS ()\nCATEGORY {category}\nEND\n'
assert Comp.from_source(None, None, source).category == 'samples'
Loading