Repository navigation
Combine McCode runs as one run of all their rays, weighted by Ncount - #400
Merged
Merged
Conversation
McCode normalises each run's intensities to its own ray count, but combining two .dat files added them, so restage's merge of a primary's passes -- its only caller -- gave histograms too intense by about the number of passes, with unweighted errors. The intensity is now the Ncount-weighted mean, its error the weighted errors in quadrature over the total, and counts still add. The header's values, signal and statistics were the first file's and are now recomputed from the combined histogram; recomputed for a single McStas file they reproduce the ones McStas wrote. A file without Ncount is refused rather than weighted equally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
McCode normalises each run's intensities to its own ray count, but combining two .dat files added them, so restage's merge of a primary's passes -- its only caller -- gave histograms too intense by about the number of passes, with unweighted errors. The intensity is now the Ncount-weighted mean, its error the weighted errors in quadrature over the total, and counts still add. The header's values, signal and statistics were the first file's and are now recomputed from the combined histogram; recomputed for a single McStas file they reproduce the ones McStas wrote. A file without Ncount is refused rather than weighted equally.